From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 415113858D28 for ; Tue, 5 Dec 2023 09:35:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 415113858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 415113858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701768939; cv=none; b=PYkWzZjCFmGJbXVPrKji/iOFSze2EwzvyjZET1h5poOZNkRvl1AI2tPTIfjxC2GutAZoUg9PgWduJ8q61ho5j5a1MT7FO2uobcJMi2mb8z1K8HPWbYMHkjd8mDuYQUWlD3ndMFYL3Epkj6nbbD3p+KDrav3yu9Lwf+0VOyi6N6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701768939; c=relaxed/simple; bh=1sWB9lGeBQR29s683ScOVNmsn/kVL567BDRUxhtdIMY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qrNJCQWqnzRejA6GKjMSv0pFsvvMHiOvkGjWLhfzdKDZ60TyyJ+G453MSguE1B7HTvtvQ4OmHjr0vcwcUJW2cy+CPyA3lgugzfARE5IiSFs6eKpFqijPzq5Fku9WPEgemTy5kB7aa/YNUsHhalnlzo3AyAdllNSQZhy0tRw7nco= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40c09dfd82aso28531435e9.0 for ; Tue, 05 Dec 2023 01:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701768937; x=1702373737; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DR7nyqo3r8At/Hk9erPhKDYkmaDVY43KuAMSx0A78KQ=; b=TaxC5xbw6SF20Zr3ccW3any5RBEM10CLQ13hr3hEa2veOs+UI0pKUSvL7YTR1Chx5U gaiUF3kAm1QX8BLrUQVKicXbibmelLgb2NV6E+rg5rfdKXPC2OZb5Pwx6JQuhDPBvgMJ iUtyp0I5/ae88cBLAdR2OWrueCa6jbEkdGAgU3Jy8p6HIii402+bAZIDecRmZzfuiayi mUYUgj08qSFLbL6ky/E+s+ivdJJTN1+jYWgmmgdBN9rKeqmflWqs9dB/SnNv/S+s4FOT UVAyRm2TgmE5NaaWvMazZ/iTYaP6Nz/kFV9DddF8Xrfj3XoRYd3F/pMPqJHx+buKfOv4 JuXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701768937; x=1702373737; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DR7nyqo3r8At/Hk9erPhKDYkmaDVY43KuAMSx0A78KQ=; b=c6vFlnugz3RmV4lJo00LjxEowkyBYucyxsLEwYBiegJ2xkVh0dCJOAXc8xpHBPEGFM gDLbzBIHZVO0yNy2iCArqhWVO/UoL80F+Hb62Z65JYzB/ufoc66cHkcALKsoqlw+Yspe RMH8dsa/yOyOYBxrkREEZJYGwQdGgCaDi6saF4U2Mg7oBPn+M776Ajf9XP2fLdQGdmXP 4xeGjbYpTqWHOopPvpPma5J+j2hYptnl6fqNyLOuhsyDDvJwYMqhZA3BTwdLpILYHhGZ 2n33jIBSL0zamuDeQG7wzuu7QehedYxt2lg5C7nkOsNW+XksRQVZGme06jnzh8U6vwNf I1cg== X-Gm-Message-State: AOJu0YzAehxGqJU/GJtsncL3CyCWh0bv0zWNfEMeBy3EvKKV2AhYVuf1 b80bXm37FJ8bBqAVt5yqFWzL8TTnF+pc4fHfrNg= X-Google-Smtp-Source: AGHT+IEb8z2o/fLJtP8jml4EWFEybpRNyzyQYdiOR5k7cPHxIdLPLq1g7xRQu0tR6DlTnuCZWry4ug== X-Received: by 2002:a05:600c:43d5:b0:40b:5e59:cca9 with SMTP id f21-20020a05600c43d500b0040b5e59cca9mr316819wmn.138.1701768936925; Tue, 05 Dec 2023 01:35:36 -0800 (PST) Received: from [10.32.33.60] ([130.43.161.185]) by smtp.gmail.com with ESMTPSA id s9-20020a05600c45c900b0040b4fca8620sm21796566wmo.37.2023.12.05.01.35.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 01:35:36 -0800 (PST) Message-ID: <8ac74963-0268-49ab-a88c-e4bc943bea49@linaro.org> Date: Tue, 5 Dec 2023 09:35:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] gdb: Enable early init of thread pool size Content-Language: en-US To: Tom de Vries , Tom Tromey Cc: gdb-patches@sourceware.org References: <20231124161321.572511-1-richard.bunt@linaro.org> <87edgbdjyw.fsf@tromey.com> From: Richard Bunt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/12/2023 07:56, Tom de Vries wrote: > On 11/27/23 21:23, Tom Tromey wrote: >>>>>>> "Richard" == Richard Bunt writes: >> >> Richard> Updates in v4. >> Richard> Clamped the default number of worker threads to eight. I'm ok >> with this as GDB >> Richard> can always be configured to use a higher number of work >> threads if the use case >> Richard> demands it. >> >> I think these are fine.  Thank you for doing this. >> Approved-By: Tom Tromey > > I think this caused: > ... > FAIL: gdb.gdb/index-file.exp: maintenance show worker-threads > ERROR: tcl error sourcing > /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp. > ERROR: invalid bareword "UNKNOWN" > in expression "UNKNOWN / 2"; > should be "$UNKNOWN" or "{UNKNOWN}" or "UNKNOWN(...)" or ... >     (parsing expression "UNKNOWN / 2") >     invoked from within > "expr $worker_threads / 2" >     invoked from within > "if { $worker_threads > 1 } { >     # Start GDB, but don't load a file yet. >     clean_restart > >     # Adjust the number of threads to use. >     set reduced..." >     (file "/data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp" > line 127) >     invoked from within > "source /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp" >     ("uplevel" body line 1) >     invoked from within > "uplevel #0 source > /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp" >     invoked from within > "catch "uplevel #0 source $test_file_name"" > ... > > Thanks, > - Tom Thanks for flagging. I'm looking in to the issue. Rich.