From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id F2BA63858D39 for ; Tue, 2 Nov 2021 16:00:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2BA63858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id d27so16105437wrb.6 for ; Tue, 02 Nov 2021 09:00:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=8IbxfKy1dfrSXV/lQsVliEq45pSpaLvHpEYSOsycZI4=; b=j75cTwVteVK1FzmHPhAkYWVzNHBXr0ESeqB8aTaes6WOadJYXRTtP1qO3Ns0FX5Pe/ E6WKV6CacthbOM2SU5zS90lYSXjLopsgRSiQ5bMdVlYrDNBYvfcFHzJK5yNu6BLPbhk0 Q1erQMV1qivgoX4vbJuKNs6Gjhph1njy2SrYE96UCvgRQG2mwHMaDMWU8tTLEQX+oqwC Qy4WDQv8fy1zCYjzVLbFDa7kyPUXviPFLiqAcdtxfGiphp8y2Yiu2dOOBK0agkgAe0Ue z2C8cEhlGaYbsZDQx3oxzb6j+X/6PN9XCeWIxITNqdt0jIkaLZI8wB9OtiyE3VBKrZWc nsyA== X-Gm-Message-State: AOAM530obuw+j8liajKmVtdODyoKyn+YPNcEvjAlIyVO3WSmDYDjhvyb 21re+x0/JwPw1Y4WkdlD40s= X-Google-Smtp-Source: ABdhPJyrquTPvzb5ELIWRF5tRobuo1Gq9aXLhvX101kG6GkrWANtMy1TxCygn81CGslSB1LD3YpJhg== X-Received: by 2002:adf:f9d2:: with SMTP id w18mr15196703wrr.303.1635868807963; Tue, 02 Nov 2021 09:00:07 -0700 (PDT) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id u19sm3356052wmm.5.2021.11.02.09.00.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Nov 2021 09:00:06 -0700 (PDT) Message-ID: <8acafb4f-ef32-2de8-e71f-8243386b8159@palves.net> Date: Tue, 2 Nov 2021 16:00:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 2/2] Improve gdb::array_view ctor from contiguous containers Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211020200525.122108-1-lsix@lancelotsix.com> <20211020200525.122108-3-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211020200525.122108-3-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2021 16:00:12 -0000 Did you look into covering this scenario in unittests/array-view-selftests.c ?