From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52919 invoked by alias); 15 Sep 2016 14:11:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52906 invoked by uid 89); 15 Sep 2016 14:11:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=disturbing, S390 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Sep 2016 14:11:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DFCA4C05681A; Thu, 15 Sep 2016 14:11:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8FEB3EJ021651; Thu, 15 Sep 2016 10:11:03 -0400 Subject: Re: [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints To: Andreas Arnez , gdb-patches@sourceware.org References: <1473940399-2891-1-git-send-email-arnez@linux.vnet.ibm.com> Cc: Ulrich Weigand From: Pedro Alves Message-ID: <8b5f2062-d755-672d-a899-781f77baa921@redhat.com> Date: Thu, 15 Sep 2016 14:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473940399-2891-1-git-send-email-arnez@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00154.txt.bz2 On 09/15/2016 12:52 PM, Andreas Arnez wrote: > This series adds some enhancements to the current s390-linux native > support for watchpoints. It also adds hardware breakpoint support. > > While this is mostly an s390-specific series, it includes one > common-code patch: patch #5, "linux-nat: Add function lwp_is_stepping". > I'm looking for feedback on that. Comments to the s390-specific patches > are certainly welcome as well. I'm curious on the need to disable hw breakpoints when single-stepping. It's of course more efficient if we manage to disable the breakpoint just for the thread that is stepping, without disturbing other threads, but OTOH, infrun's handling of stepping over breakpoints should already be making sure that threads can step past breakpoints somehow? I.e., without displaced stepping, infrun should be removing breakpoints from all threads, and with displaced stepping, we'll be stepping the thread at a different PC so the hardware breakpoint at the original PC should not trigger. Thanks, Pedro Alves