From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150043.outbound.protection.outlook.com [40.107.15.43]) by sourceware.org (Postfix) with ESMTPS id A61693894C1A for ; Tue, 15 Nov 2022 12:57:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A61693894C1A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kNL+E1F2+ongMB66mBerJv10jL24dYtPxCm1ad4/zKCPtZQ+/iXumyo2tqDSnfKmWpm+8m8Jdhe5ABRxy1CpH5RHnGAtBmn+5YpNuawlJ/fdJBNq8Ilyq1KX2pyZyVFLvytII325NQY17iovnSMSyEULi7oyPJ42dniEArFr1D9KuzbF+GCa8gv5cjLee4IHeG7njDYxB+s0ZG0ARVS6l9JIgXwke7YUm51/VN1N4JS2Lpz3pKqfgvDzO96wbxqVnRgkGeH4Mnj/u0T6v9ZR/fvJYmKcrR7rLN5VzfM4Toie1JzgsLIcUWyPls2/vCb813hUlHpNBEwCFMVuHOHsLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rrN6O3ju+bARRRVqrAT52szPKCM3bJ7NGY4dGlycKV4=; b=mIkesH8gBKnOfP2BdShxa2NRsy9mwyMsWdPxjzAMifhFYXg16+TtCTe0Ndx499yJ9RgwIB1VTocmE+601y4FUv5pXAzcDOUnO8dszsn1WYS45Gf/stXIYmKt1obWu1Jz0gcqMO/13Qw4ueVi41Htxiv9igN9YZQpFGQhZkCewW4ZhNcq+zPguKEqdQ1sQ/f15ab1a1Hr3GY0yUzH45PCXXtPgCLrGjSSvO2YU6DL5+UeG6qH9VI61CZtanE5HZIUOt41RJdLqvIIVtmyBMtUGVHdl98rX0KTrCCW7u7tTISzK8gWwZMeYblJbBNzYwWT0JHFcrl4lRq9NoY1vGJHgQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rrN6O3ju+bARRRVqrAT52szPKCM3bJ7NGY4dGlycKV4=; b=NdpDwsR2JAkhC/DnHgE43Grjdx3sajxogCBmBas+XR+raEfgHllzDmtfm+BddIpGA2a2kUFdhBH16vUHBtZGJ+z/d0FVbfmstuV0dmG3s2snPZr6+8oM214h3qniYVHp7aqnOry1SgKdlCUSpg33Xxlofa4P1tOTaGgQQhr8Nk4= Received: from AS9PR06CA0151.eurprd06.prod.outlook.com (2603:10a6:20b:45c::8) by DB9PR08MB9636.eurprd08.prod.outlook.com (2603:10a6:10:45c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Tue, 15 Nov 2022 12:57:30 +0000 Received: from AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45c:cafe::cc) by AS9PR06CA0151.outlook.office365.com (2603:10a6:20b:45c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Tue, 15 Nov 2022 12:57:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT013.mail.protection.outlook.com (100.127.140.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 15 Nov 2022 12:57:30 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Tue, 15 Nov 2022 12:57:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fa14c3628e4dfd6f X-CR-MTA-TID: 64aa7808 Received: from 180a054b32fd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 984F241A-28C5-4C7D-9247-164CE2AAA2D2.1; Tue, 15 Nov 2022 12:57:22 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 180a054b32fd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Nov 2022 12:57:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ys67dHtdXsIKJ5lja7h+WAHc6QMLT128tUU9Rj+IYKSMRE/hVPi6mNdJZK5rEYSxXMDeZL9rlxMbUwtYvR9j+CQYOnWkJAEwFE5nYjRmG8VdBpwad6qBzjjLZ7xYvbqmve8pZnEwIA6b03fXVxzZ+YwqXc2G0KDW47BUNshRj78kVoui9JmGLV+Rh5pHiEZpKg49Iofzok20LzOC4mDhlf4bkNRavxHO/ugDqmW/QPS9HwUYqNs5NEdEQ84PE+XoQj7hPuHrXP1MTRcRt3c10QvWwmSN3PIx/uBvOmi4ujcbEnnkPPtVJ2ll9BD1/v5V1Q3k7vR+Qlo5WdesxB5CKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rrN6O3ju+bARRRVqrAT52szPKCM3bJ7NGY4dGlycKV4=; b=AoZnt/Beb8G9FMZYGAwBhmT+U4yC7bi/1ZEurl9DyR4pq3cMzuv9hZMoccIr4pG2VLttspoB2GhNorGD85G+2U4ReaI/ucH+3ogoyr1ehEzJ/Mh9+p3qSy4EuTLNJuimiu+pxBDJkVQ3krzQSMrM/5NE5NxnQLnnjqDT7nO8iE9GQ5ckeMO5vxk5DshdCoTEwoLfjfD8yi3OKbRdNsb0orsDYEXLkNd++LqMIJFyZXvg327g/pNjkqzj1TwL6Sjzk4POo6U2plPBhUjChSLxXYgyxRBCID+ylnapEKcCxWFcXuk3fULH7/StsAoqZZsYkWLe3zecSoFXELBY8PZ7tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rrN6O3ju+bARRRVqrAT52szPKCM3bJ7NGY4dGlycKV4=; b=NdpDwsR2JAkhC/DnHgE43Grjdx3sajxogCBmBas+XR+raEfgHllzDmtfm+BddIpGA2a2kUFdhBH16vUHBtZGJ+z/d0FVbfmstuV0dmG3s2snPZr6+8oM214h3qniYVHp7aqnOry1SgKdlCUSpg33Xxlofa4P1tOTaGgQQhr8Nk4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV1PR08MB7348.eurprd08.prod.outlook.com (2603:10a6:150:23::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Tue, 15 Nov 2022 12:57:18 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801%5]) with mapi id 15.20.5834.006; Tue, 15 Nov 2022 12:57:17 +0000 Message-ID: <8b6e0043-5851-0d6a-ef11-51d95e688a88@arm.com> Date: Tue, 15 Nov 2022 12:57:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] [gdb/testsuite] Skip aarch64 in skip_gdbserver_test if no xml support Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20221115125426.27370-1-tdevries@suse.de> From: Luis Machado In-Reply-To: <20221115125426.27370-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0136.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV1PR08MB7348:EE_|AM7EUR03FT013:EE_|DB9PR08MB9636:EE_ X-MS-Office365-Filtering-Correlation-Id: ccddcfd7-ca1d-4ae7-643e-08dac708f475 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oes8Vg1fBeT7yoj7TnT5HByXQrsGpLgqiw+GcMWs7s/9noZ6O1vxpKJLmMtKGN9CkeLbHuWDj17Pv0LRK51p526wHRbsjt4XcWcDZAq16iZXBLrb1YyIdamCGua9lpLMGjX7Z/uN/lyM23etPRtELRlTX5AU4mHJVLB/W7We9GEoTuKvaYT5xhLJyPfFdfkJMIntsKV1LORUTLJJ4Nn47ejx13klFEzDMU/Ifqf2cYYK8v8NGXManJJ5LiGuBEsPe6QytSQ7ZUSpPFdTdJT90LhlLsYQ/jOl31zn9tXRcT0vTaZxhHGPYZMzx3F0aV/PB0XyVs4cDhzFf4Nu5lXk0LlMPj6LZ4XH9fJ5SzVLa+A3JUBWrRIR5qNTpMfHZZi/BTfVNGaX5oiR/ONPwZSxVc02sT54wNAJVeEGXkKwzNoL+mV0KxjraW/i19JqryCCwny08n0hOJBGE1iw1JYZNPbidcnSHfz7UbWnbRYkLcllF94OdLdmMn9kEFMbYtiAX1zHjTXt6UDvkeG41TURxgni3E/pl2BTI25F7h0S3TPkQacNPQBE+JC3gLqb9PuKK0FLw2Elvdbs66fyYb9YzLr+5NCIt6X8XP/CaN31GhyKuceYzmlG1VqKLN3ajbd1UcPUf382D68sbq/9ENgXg4niXs8zalH4hbuhrQSa3qeumikZ65F63tMMs6tXBQYmYBeCto5Db8VdYHntzKfbIxrS5jZbfHX5IJ380lu4/5Qupq012aod7KQL/hQ8GORuES13jpKD41CtUibjD6hkAgVu6X9+LIiaVvng+gMDz9M= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199015)(83380400001)(31686004)(2906002)(66476007)(2616005)(86362001)(186003)(36756003)(41300700001)(31696002)(8676002)(38100700002)(316002)(66556008)(66946007)(8936002)(53546011)(478600001)(44832011)(6486002)(6666004)(6506007)(6512007)(5660300002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7348 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2d76f493-9588-4614-d1e7-08dac708ec90 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ygQB7EcHXCE47shBR//xaXoN7FGNbPgCZV3Qjs2WUwaqklYsieJVQ7U7yLAmTQQy+2qn94ITqk9hWWQRVGg+wGfnDSJftClovxQQayjj19S3g1qctVkwOEdnlzU/DUeSQm4CJAaXguVbjaA3gAiyxA6KEZ3DSjB9O2+AuhQTf1T2PLKxRytfPOLwm//nrWfkohKyEGuY8tiWMcOOtfbGxdclIocsf5sbAdVOHVsV6Td+Yz+9xFTo26Ev5DABLyyvkodEIqXGyDB9JLsL40Xwj6sHgjla2t5OifSmkfu2OrHIHxkmjMN6+Tqhi20txw/5ow8FqLfSMPbiTf3AhWXB+DL7KWz91g30fQghHusegVEsuUokgP0uPNh+WVmAjgvSqEECMjUJsAV2FLlwzelVJtVlcpKrVVSrxmKTV+uYb5k9Mj6ii8K2TU/H1T5htFwOFQHb+Mh3j5RyaUS7LxClX8LZnVQ5ryxtQwfX17WLEtg2HsYlvWnIf+y930a+odNgOeZqVmVmn4krcxoBDZdG0uN2wyOqM28vPh2FSgws7jWQQP+NVtOuKbL5xvp+soAAcU2smasnInyh0yyHWoxIr6WRXR68r8YQ3RPQHEi8mpUJn1hBfH48Qz6PoC4znI1wC8s/uea4BLi9HPMEd75BdPlIK3MG4V3UrXtnlL7BSo7wB4wIOcTkdgcZ1n2u/iKBA2CWzTG2uBvUWCfRafbuvyavbeH2TctpYh9McKQcArl2kLC3fXXxEBfAwAjXt4Nj6qWLxUIBjTZD6hZTbI21F3On+TLlAmjqyKIuiwSSZeV56jDDM4RVTN+RxSYMqzjj X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(70206006)(8936002)(70586007)(8676002)(82310400005)(83380400001)(41300700001)(86362001)(31696002)(40460700003)(316002)(47076005)(36860700001)(82740400003)(36756003)(44832011)(356005)(81166007)(40480700001)(5660300002)(6666004)(6486002)(478600001)(31686004)(2616005)(6506007)(186003)(6512007)(2906002)(53546011)(26005)(336012)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:57:30.0877 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ccddcfd7-ca1d-4ae7-643e-08dac708f475 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9636 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, On 11/15/22 12:54, Tom de Vries wrote: > From: Tom de Vries > > On aarch64-linux, with a gdb build without libexpat, so without xml support, I > run into: > ... > (gdb) builtin_spawn attach-no-multi-process^M > attach 26808^M > Attaching to Remote target^M > warning: Can not parse XML target description; XML support was disabled at \ > compile time^M > Reading symbols from attach-no-multi-process...^M > Remote 'g' packet reply is too long (expected 788 bytes, got 796 bytes): ... ^M > ... > > The test-case checks for skip_gdbserver_tests and that one contains a check > for xml support: > ... > # If GDB is lack of XML support, and targets, like arm, have > # multiple target descriptions, GDB doesn't know which target > # description GDBserver uses, and may fail to parse 'g' packet > # after connection. > if { [gdb_skip_xml_test] > && ([istarget "arm*-*-linux*"] > || [istarget "mips*-*-linux*"] > || [istarget "powerpc*-*-linux*"] > || [istarget "s390*-*-linux*"] > || [istarget "x86_64-*-linux*"] > || [istarget "i\[34567\]86-*-linux*"]) } { > return 1 > } > ... > but it doesn't trigger because aarch64 is missing. > > Fix this by adding istarget "aarch64*-*-linux*". > > Tested on aarch64-linux. > --- > gdb/testsuite/lib/gdbserver-support.exp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp > index 3f2cec246fa..c9f0c35c07e 100644 > --- a/gdb/testsuite/lib/gdbserver-support.exp > +++ b/gdb/testsuite/lib/gdbserver-support.exp > @@ -173,6 +173,7 @@ proc skip_gdbserver_tests { } { > # after connection. > if { [gdb_skip_xml_test] > && ([istarget "arm*-*-linux*"] > + || [istarget "aarch64*-*-linux*"] > || [istarget "mips*-*-linux*"] > || [istarget "powerpc*-*-linux*"] > || [istarget "s390*-*-linux*"] Thanks for spotting this. LGTM.