From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Mike Frysinger <vapier@gentoo.org>,
Andrew Burgess <aburgess@redhat.com>,
Tom de Vries <tdevries@suse.de>, Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: [PATCH v3] sim, sim/{m32c,ppc,rl78}: Use getopt_long
Date: Wed, 26 Oct 2022 10:59:31 +0000 [thread overview]
Message-ID: <8b72df6380c6df7a34d01802e7581bbfb5c0b1a5.1666781905.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <7ad71357e72129e5dc642a5233868b3aa81c484c.1666679042.git.research_trasio@irq.a4lg.com>
Because of a Libiberty hack, getopt on GNU libc (2.25 or earlier) is
currently unusable on sim, causing a regression on CentOS 7.
This is caused as follows:
1. If HAVE_DECL_GETOPT is defined (getopt declaration with known prototype
is detected while configuration), a declaration of getopt in
"include/getopt.h" is suppressed.
The author started to define HAVE_DECL_GETOPT in sim with the commit
340aa4f6872c ("sim: Check known getopt definition existence").
2. GNU libc (2.25 or earlier)'s <unistd.h> includes <getopt.h> with a
special purpose macro defined to declare only getopt function but due
to include path (not tested while configuration), it causes <unistd.h>
to include Libiberty's "include/getopt.h".
3. If both 1. and 2. are satisfied, despite that <unistd.h> tries to
declare getopt by including <getopt.h>, "include/getopt.h" does not do
so, causing getopt function undeclared.
Getting rid of "include/getopt.h" (e.g. renaming this header file) is the
best solution to avoid hacking but as a short-term solution, this commit
replaces getopt with getopt_long under sim/.
---
sim/igen/igen.c | 6 ++++--
sim/m32c/main.c | 5 ++++-
sim/ppc/dgen.c | 6 ++++--
sim/ppc/igen.c | 9 ++++++---
sim/rl78/main.c | 4 +++-
5 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/sim/igen/igen.c b/sim/igen/igen.c
index ba856401fa9..06ee5fdfd10 100644
--- a/sim/igen/igen.c
+++ b/sim/igen/igen.c
@@ -989,6 +989,7 @@ main (int argc, char **argv, char **envp)
char *real_file_name = NULL;
int is_header = 0;
int ch;
+ struct option longopts[] = { { 0 } };
lf *standard_out =
lf_open ("-", "stdout", lf_omit_references, lf_is_text, "igen");
@@ -1162,8 +1163,9 @@ main (int argc, char **argv, char **envp)
printf (" -t <output-file> output itable\n");
}
- while ((ch = getopt (argc, argv,
- "B:D:F:G:H:I:M:N:P:T:W:o:k:i:n:hc:d:e:m:r:s:t:f:x"))
+ while ((ch = getopt_long (argc, argv,
+ "B:D:F:G:H:I:M:N:P:T:W:o:k:i:n:hc:d:e:m:r:s:t:f:x",
+ longopts, NULL))
!= -1)
{
#if 0 /* For debugging. */
diff --git a/sim/m32c/main.c b/sim/m32c/main.c
index 958ca27ab2b..5d6686d702e 100644
--- a/sim/m32c/main.c
+++ b/sim/m32c/main.c
@@ -29,6 +29,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <setjmp.h>
#include <signal.h>
#include <sys/types.h>
+#include <getopt.h>
#ifdef HAVE_SYS_SOCKET_H
#ifdef HAVE_NETINET_IN_H
@@ -135,12 +136,14 @@ main (int argc, char **argv)
#ifdef HAVE_networking
char *console_port_s = 0;
#endif
+ struct option longopts[] = { { 0 } };
setbuf (stdout, 0);
in_gdb = 0;
- while ((o = getopt (argc, argv, "tc:vdm:C")) != -1)
+ while ((o = getopt_long (argc, argv, "tc:vdm:C", longopts, NULL))
+ != -1)
switch (o)
{
case 't':
diff --git a/sim/ppc/dgen.c b/sim/ppc/dgen.c
index a1c1d56e8dc..277f3ab1d89 100644
--- a/sim/ppc/dgen.c
+++ b/sim/ppc/dgen.c
@@ -271,6 +271,7 @@ main(int argc,
{
lf_file_references file_references = lf_include_references;
spreg_table *sprs = NULL;
+ struct option longopts[] = { { 0 } };
char *real_file_name = NULL;
int is_header = 0;
int ch;
@@ -284,8 +285,9 @@ main(int argc,
printf("-L Suppress cpp line numbering in output files\n");
}
-
- while ((ch = getopt(argc, argv, "hLsn:r:p:")) != -1) {
+ while ((ch = getopt_long (argc, argv, "hLsn:r:p:", longopts, NULL))
+ != -1)
+ {
#if 0 /* For debugging. */
fprintf(stderr, "\t-%c %s\n", ch, ( optarg ? optarg : ""));
#endif
diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c
index 27b48638276..8711394637a 100644
--- a/sim/ppc/igen.c
+++ b/sim/ppc/igen.c
@@ -351,6 +351,7 @@ main(int argc,
filter *filters = NULL;
insn_table *instructions = NULL;
table_include *includes = NULL;
+ struct option longopts[] = { { 0 } };
char *real_file_name = NULL;
int is_header = 0;
int ch;
@@ -390,9 +391,11 @@ main(int argc,
printf(" -f <output-file> output support functions\n");
}
- while ((ch = getopt(argc, argv,
- "F:EI:RSLJT:CB:H:N:o:k:i:n:hc:d:m:s:t:f:"))
- != -1) {
+ while (
+ (ch = getopt_long (argc, argv, "F:EI:RSLJT:CB:H:N:o:k:i:n:hc:d:m:s:t:f:",
+ longopts, NULL))
+ != -1)
+ {
#if 0 /* For debugging. */
fprintf(stderr, "\t-%c %s\n", ch, (optarg ? optarg : ""));
#endif
diff --git a/sim/rl78/main.c b/sim/rl78/main.c
index c9459c7bc78..bc8dd1a0697 100644
--- a/sim/rl78/main.c
+++ b/sim/rl78/main.c
@@ -64,10 +64,12 @@ main (int argc, char **argv)
int save_trace;
bfd *prog;
int rc;
+ struct option longopts[] = { { 0 } };
xmalloc_set_program_name (argv[0]);
- while ((o = getopt (argc, argv, "tvdr:D:M:")) != -1)
+ while ((o = getopt_long (argc, argv, "tvdr:D:M:", longopts, NULL))
+ != -1)
{
switch (o)
{
base-commit: 99033a63c7ba0997ef737392eef15337d6783078
--
2.37.2
next prev parent reply other threads:[~2022-10-26 10:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3b7e769f-b5e9-4049-786f-d00d997f0280@irq.a4lg.com>
2022-10-18 17:13 ` [PATCH] sim, sim/m32c, sim/rl78: " Tsukasa OI
2022-10-21 16:27 ` Tom Tromey
2022-10-24 7:51 ` Tsukasa OI
2022-10-25 5:53 ` Tsukasa OI
2022-10-25 16:54 ` Tom Tromey
2022-10-25 17:17 ` Tsukasa OI
2022-10-25 19:42 ` Tom Tromey
2022-10-25 6:27 ` [PATCH v2] sim, sim/{m32c,ppc,rl78}: " Tsukasa OI
2022-10-26 8:59 ` Mike Frysinger
2022-10-26 10:57 ` Tsukasa OI
2022-10-26 16:01 ` Mike Frysinger
2022-10-27 1:29 ` Tsukasa OI
2022-10-26 10:59 ` Tsukasa OI [this message]
2022-10-27 1:23 ` [PATCH v4] " Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b72df6380c6df7a34d01802e7581bbfb5c0b1a5.1666781905.git.research_trasio@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=tdevries@suse.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).