From: Kamil Rytarowski <kamil@netbsd.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
John Baldwin <jhb@freebsd.org>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v2 1/2] gdb: Implement native dumpcore function
Date: Tue, 28 Jul 2020 22:39:20 +0200 [thread overview]
Message-ID: <8b7b174f-a88f-df0f-272a-4d189c829652@netbsd.org> (raw)
In-Reply-To: <CAPTJ0XHQ_q6JsLrP8+Xsopv-f2tyRUCqEYDTf6zXzBOu2CjAaA@mail.gmail.com>
On 28.07.2020 20:56, Christian Biesinger wrote:
> On Tue, Jul 28, 2020 at 10:47 AM Kamil Rytarowski <n54@gmx.com> wrote:
>> +++ b/gdb/target.h
>> +/* Does this target support dumpcore API? */
>> +
>> +#define target_supports_dumpcore() \
>> + (current_top_target ()->supports_dumpcore) ()
>> +
>> +/* Generate the core file with target API. */
>> +
>> +#define target_dumpcore(x) \
>> + (current_top_target ()->dumpcore (x))
>
> These macros don't seem that useful to me, and they hide a global
> variable access... would it be possible to remove them?
>
I have got no preference myself, but preexisting code uses the macros.
If you want to remove them, please do it as an independent patch.
> Christian
>
next prev parent reply other threads:[~2020-07-28 20:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:43 [PATCH] " Kamil Rytarowski
2020-07-27 15:47 ` John Baldwin
2020-07-27 21:09 ` Tom Tromey
2020-07-28 15:46 ` [PATCH v2 1/2] " Kamil Rytarowski
2020-07-28 15:46 ` [PATCH v2 2/2] gdb: Implement native dumpcore function for NetBSD Kamil Rytarowski
2020-08-05 16:24 ` Tom Tromey
2020-08-13 17:16 ` Kamil Rytarowski
2020-07-28 18:56 ` [PATCH v2 1/2] gdb: Implement native dumpcore function Christian Biesinger
2020-07-28 20:39 ` Kamil Rytarowski [this message]
2020-07-29 15:45 ` Tom Tromey
2020-08-05 16:23 ` Tom Tromey
2020-08-13 17:15 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b7b174f-a88f-df0f-272a-4d189c829652@netbsd.org \
--to=kamil@netbsd.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).