From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id BE65A3858C50 for ; Fri, 22 Jul 2022 22:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE65A3858C50 Received: from [192.168.0.128] ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 26MMju6p024994 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK); Sat, 23 Jul 2022 00:46:02 +0200 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 26MMju6p024994 Message-ID: <8b9d291b-c05f-52de-dd34-a644102a9aae@monnerat.net> Date: Sat, 23 Jul 2022 00:45:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Add a timeout parameter to gdb_do_one_event Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220317130846.162955-1-patrick@monnerat.net> <578979e9-353c-fd92-853a-b78af2afd8ad@simark.ca> From: Patrick Monnerat In-Reply-To: <578979e9-353c-fd92-853a-b78af2afd8ad@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 22:46:09 -0000 On 7/22/22 15:41, Simon Marchi wrote: > > On 2022-03-17 09:08, Patrick Monnerat via Gdb-patches wrote: >> Since commit b2d8657, having a per-interpreter event/command loop is not >> possible anymore. >> >> As Insight uses a GUI that has its own event loop, gdb and GUI event >> loops have then to be "merged" (i.e.: work together). But this is >> problematic as gdb_do_one_event is not aware of this alternate event >> loop and thus may wait forever. >> >> The solution is to implement a wait timeout to gdb_do_one_event. This >> cannot be done externally as gdb timers are event sources themselves. >> >> The new parameter defaults to "no timeout": as it is used by Insight >> only, there is no need to update calls from the gdb source tree. Hi Simon, > Sorry for the delay. Never mind! > The patch is fine with me. Pedro and Tom also > took a look at previous iterations and I didn't see any disagreement > either. Thanks to you and mates for these reviews and advice. > I don't remember, do you have push access? Otherwise I can > push it for you. No, I haven't. That's why I'm pinging many times! Thanks in advance for commit. BTW: would it be possible to get push access ? How ? I still have some patches (all related to insight) to submit and want to speed up a bit the process (without skipping this list, of course!) and discharge you from this task. Patrick