Re: [PATCH 1/2] gdb: testsuite: remove pass statement in can_spawn_for_attach

[Tiezhu Yang <yangtiezhu@loongson.cn>]

On 03/16/2022 09:21 AM, Simon Marchi wrote:
> Hi Tiezhu,
>
> Did you consider changing the approach to what Pedro suggested here?
>
> https://sourceware.org/pipermail/gdb-patches/2022-March/186311.html
>
> I have to admit that I approved your patch because I didn't really have
> a better suggestion, and I know that it's a real problem (which I
> encounter myself sometimes).  But Pedro's suggestion seems more
> straightforward.

OK, thank you, I will send patches later.

Thanks,
Tiezhu

>
> Simon
>
> On 2022-03-04 05:15, Tiezhu Yang wrote:
>> After execute the following command:
>>
>>   make check-gdb TESTS="gdb.base/attach-pie-noexec.exp"
>>
>> we can see the following messages in gdb/testsuite/gdb.log:
>>
>>   (gdb) gdb_do_cache_wrap ignoring pass: can spawn for attach
>>
>> the pass statement is ignored, just remove them in can_spawn_for_attach.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>  gdb/testsuite/lib/gdb.exp | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
>> index a35d08a..f21b22c 100644
>> --- a/gdb/testsuite/lib/gdb.exp
>> +++ b/gdb/testsuite/lib/gdb.exp
>> @@ -5111,7 +5111,6 @@ gdb_caching_proc can_spawn_for_attach {
>>      file delete $obj
>>      gdb_test_multiple "attach $test_pid" "can spawn for attach" {
>>          -re -wrap "Attaching to process $test_pid\r\n.*No executable file now.*" {
>> -          pass $gdb_test_name
>>            kill_wait_spawned_process $test_spawn_id
>>            return 1
>>          }
>> @@ -5126,7 +5125,6 @@ gdb_caching_proc can_spawn_for_attach {
>>            return 0
>>          }
>>          -re -wrap "Attaching to process $test_pid\r\n.*XML support was disabled at compile time.*" {
>> -          pass $gdb_test_name
>>            kill_wait_spawned_process $test_spawn_id
>>            return 1
>>          }