From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id DADCA385E83E for ; Wed, 16 Mar 2022 06:15:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DADCA385E83E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.130.0.135] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dx389rgDFixhEKAA--.30852S3; Wed, 16 Mar 2022 14:15:08 +0800 (CST) Subject: Re: [PATCH 1/2] gdb: testsuite: remove pass statement in can_spawn_for_attach To: Simon Marchi , gdb-patches@sourceware.org References: <1646388927-28165-1-git-send-email-yangtiezhu@loongson.cn> From: Tiezhu Yang Message-ID: <8bf63d2d-f1b3-9699-fed4-2757986050ba@loongson.cn> Date: Wed, 16 Mar 2022 14:15:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf9Dx389rgDFixhEKAA--.30852S3 X-Coremail-Antispam: 1UD129KBjvJXoW7KrykCF4rJr4kZr4fZFWkWFg_yoW8Aw45pa 18tF4jyF18X3W3uFZ2y348J3sYy34Fvr98G3yayw1fuws8WFy8Jry8Kw4Y9F93XrZ29w4f Z3Z2qa15ZFW5tFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvIb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwV C2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l c2xSY4AK67AK6r47MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I 0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWU XVWUAwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcV CY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf 9x07bwQ6XUUUUU= X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 06:15:29 -0000 On 03/16/2022 09:21 AM, Simon Marchi wrote: > Hi Tiezhu, > > Did you consider changing the approach to what Pedro suggested here? > > https://sourceware.org/pipermail/gdb-patches/2022-March/186311.html > > I have to admit that I approved your patch because I didn't really have > a better suggestion, and I know that it's a real problem (which I > encounter myself sometimes). But Pedro's suggestion seems more > straightforward. OK, thank you, I will send patches later. Thanks, Tiezhu > > Simon > > On 2022-03-04 05:15, Tiezhu Yang wrote: >> After execute the following command: >> >> make check-gdb TESTS="gdb.base/attach-pie-noexec.exp" >> >> we can see the following messages in gdb/testsuite/gdb.log: >> >> (gdb) gdb_do_cache_wrap ignoring pass: can spawn for attach >> >> the pass statement is ignored, just remove them in can_spawn_for_attach. >> >> Signed-off-by: Tiezhu Yang >> --- >> gdb/testsuite/lib/gdb.exp | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index a35d08a..f21b22c 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -5111,7 +5111,6 @@ gdb_caching_proc can_spawn_for_attach { >> file delete $obj >> gdb_test_multiple "attach $test_pid" "can spawn for attach" { >> -re -wrap "Attaching to process $test_pid\r\n.*No executable file now.*" { >> - pass $gdb_test_name >> kill_wait_spawned_process $test_spawn_id >> return 1 >> } >> @@ -5126,7 +5125,6 @@ gdb_caching_proc can_spawn_for_attach { >> return 0 >> } >> -re -wrap "Attaching to process $test_pid\r\n.*XML support was disabled at compile time.*" { >> - pass $gdb_test_name >> kill_wait_spawned_process $test_spawn_id >> return 1 >> }