public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@linaro.org>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] gdb: Enable finish command and inferior calls for _Float16 on amd64 and i386.
Date: Fri, 30 Jul 2021 09:04:16 -0300	[thread overview]
Message-ID: <8c1dbaf9-5d1c-a1b6-6e2d-c16f456ecb6f@linaro.org> (raw)
In-Reply-To: <DM8PR11MB5733626B5BD0043AD2AA8FBF8EEC9@DM8PR11MB5733.namprd11.prod.outlook.com>

On 7/30/21 4:52 AM, Willgerodt, Felix wrote:
>> Is _Float16 equivalent to fp16? If so, the presence of yet another name for a
>> fp16 type is a bit unfortunate.
>>
> 
> They are the same usually, but on ARM the story is apparently a bit more complex:
> https://gcc.gnu.org/onlinedocs/gcc/Half-Precision.html

It is. :-)

> 
> But to cite the link:
> " The __fp16 type may only be used as an argument to intrinsics defined in
> <arm_fp16.h>, or as a storage format."
> 
> And:
> "It is recommended that portable code use the _Float16 type defined by
> ISO/IEC TS 18661-3:2015."
> 
> Therefore I don't think it is that unfortunate and not really negotiable by now.
> Both GCC and clang know about both already.

The unfortunate bit is the lack of enough DWARF information to make the 
distinction between different float formats of the same size. If the 
compilers are OK with the naming and already support it, it's not a big 
deal then.

> 
>>> -  if (type->code () == TYPE_CODE_FLT)
>>> +  /* _FLoat16 and _Float16 _Complex values are returned via xmm0.  */
>>
>> _Float16
>>
> 
> Thanks for spotting this. I fixed it locally.
> 
>>> +/* Test program for bfloat16 of AVX 512 registers.
>>
>> float16 and not bfloat16, right?
>>
> 
> Thanks. I reworded it to say:
> "Test program for _Float16 parameters and return values."
> 
> Regards,
> Felix
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
> 

  reply	other threads:[~2021-07-30 12:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  8:38 [PATCH 0/2] Add AVX512-FP16 support Felix Willgerodt
2021-07-29  8:38 ` [PATCH 1/2] Add half support for AVX512 register view Felix Willgerodt
2021-09-03 12:30   ` Simon Marchi
2021-09-03 12:55     ` Willgerodt, Felix
2021-09-03 12:59       ` Simon Marchi
2021-07-29  8:38 ` [PATCH 2/2] gdb: Enable finish command and inferior calls for _Float16 on amd64 and i386 Felix Willgerodt
2021-07-29 16:03   ` Luis Machado
2021-07-30  7:52     ` Willgerodt, Felix
2021-07-30 12:04       ` Luis Machado [this message]
2021-09-03 12:37         ` Simon Marchi
2021-09-03 14:00           ` Willgerodt, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c1dbaf9-5d1c-a1b6-6e2d-c16f456ecb6f@linaro.org \
    --to=luis.machado@linaro.org \
    --cc=felix.willgerodt@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).