From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id CA90F385740E for ; Fri, 30 Jul 2021 12:04:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA90F385740E Received: by mail-pj1-x102a.google.com with SMTP id mz5-20020a17090b3785b0290176ecf64922so20424765pjb.3 for ; Fri, 30 Jul 2021 05:04:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=amIdAB+SEBIavxJghdJZXwbNFWWsTjN7VKtoKAPWTdQ=; b=Y9ad4fdcHGOr6CciMGoEOmlvrE9emMvbDErRG8i/6BJXya92AyNLIHw+k2VoWqkol3 aEiK08ZrCC/7HiD4+/lmw34NvK0faSo4WxMipAuFwm18Q9eGuP56He+wDJrngIT/6A9w 3f0a8WOgxQ8VIKxMGAPuNrAZApsgk1ex7pmPheb66z6f685UcD40AZJ5K1aOF4bdJiv/ 4Pi/KWFUqxtKxDdaIiON5vyBoATwD0rEJtWOiU9j3AHogHLgpL76Dsa2umdlMv8OE6Qb 8RpEToPrSVgCFODyOWbLg5c+igygmQORPb4j9NzmzH/DxYlU+h/E1NLfQ//p0cuJoGB1 NKuA== X-Gm-Message-State: AOAM532dOy+IctksmApdfsZH5ranJZGyPgy5sfAUwrgXxHcVVKEhI1Lb eLvz9yZGQvxq3XoXoPPsXSb5fHyqH8M1Sg== X-Google-Smtp-Source: ABdhPJwuiI2N8uY3xPxFB+S+BA1OMxvyOofAmuXR7A3FruZpjotAavPHnTTAmKuleg4Otz2Cl4Ax6w== X-Received: by 2002:aa7:98c6:0:b029:32e:608b:7e86 with SMTP id e6-20020aa798c60000b029032e608b7e86mr2534235pfm.68.1627646660734; Fri, 30 Jul 2021 05:04:20 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:25bc:391a:6fe6:3de7:130a? ([2804:7f0:4841:25bc:391a:6fe6:3de7:130a]) by smtp.gmail.com with ESMTPSA id y8sm2342787pfe.162.2021.07.30.05.04.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 05:04:20 -0700 (PDT) Subject: Re: [PATCH 2/2] gdb: Enable finish command and inferior calls for _Float16 on amd64 and i386. To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" References: <20210729083833.2483704-1-felix.willgerodt@intel.com> <20210729083833.2483704-3-felix.willgerodt@intel.com> <64bffa82-0520-d0aa-786b-4d81142b977f@linaro.org> From: Luis Machado Message-ID: <8c1dbaf9-5d1c-a1b6-6e2d-c16f456ecb6f@linaro.org> Date: Fri, 30 Jul 2021 09:04:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jul 2021 12:04:23 -0000 On 7/30/21 4:52 AM, Willgerodt, Felix wrote: >> Is _Float16 equivalent to fp16? If so, the presence of yet another name for a >> fp16 type is a bit unfortunate. >> > > They are the same usually, but on ARM the story is apparently a bit more complex: > https://gcc.gnu.org/onlinedocs/gcc/Half-Precision.html It is. :-) > > But to cite the link: > " The __fp16 type may only be used as an argument to intrinsics defined in > , or as a storage format." > > And: > "It is recommended that portable code use the _Float16 type defined by > ISO/IEC TS 18661-3:2015." > > Therefore I don't think it is that unfortunate and not really negotiable by now. > Both GCC and clang know about both already. The unfortunate bit is the lack of enough DWARF information to make the distinction between different float formats of the same size. If the compilers are OK with the naming and already support it, it's not a big deal then. > >>> - if (type->code () == TYPE_CODE_FLT) >>> + /* _FLoat16 and _Float16 _Complex values are returned via xmm0. */ >> >> _Float16 >> > > Thanks for spotting this. I fixed it locally. > >>> +/* Test program for bfloat16 of AVX 512 registers. >> >> float16 and not bfloat16, right? >> > > Thanks. I reworded it to say: > "Test program for _Float16 parameters and return values." > > Regards, > Felix > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >