From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DB8A23856DCB for ; Tue, 9 Aug 2022 16:53:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB8A23856DCB Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-283-XaOSRBaTPIiF8jaDJLlpKQ-1; Tue, 09 Aug 2022 12:53:08 -0400 X-MC-Unique: XaOSRBaTPIiF8jaDJLlpKQ-1 Received: by mail-ed1-f71.google.com with SMTP id n8-20020a05640205c800b00434fb0c150cso7511454edx.19 for ; Tue, 09 Aug 2022 09:53:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=lwatDt2VDXvKyRw3qckW/c975viVI0dx35/GbKNxeyI=; b=qcimUWxZ2Fjg+irYyjXYQrhTNgWhiJgiiB3utqaiSvDiZuU4qGSfeDAMdQeVq4cl42 46gea1KDMuA3WOQukOvAT4x1ZMpbaPX/8BuSC9Ejw+XLf9Gr4OcS6CNpHQS0k/Wnq/oC Kr80ovNwA+VpQtkbyTZqm15H8TG25Z+RPcgmyJKofgaYDCkzmLs4pDwPYox27XGCTdGs kIbhSKhHgrvwBAFzQGVe4sgc4jeQ8D8t4RwAbY+HZSqavjXSliVSiLcTtjUXEkKxzsiT ARf0yrCzwRng+jjSCNXhi9aZxwwoeirWLxf/css0w1Vajqe8SP/gwJ4cui7M4k3oxYLB NVmw== X-Gm-Message-State: ACgBeo1qeOJX1/llbTH0wjVP/m+0prxPiSugvdAj0SF81VjTyhoPGvJA NIwKDHIzGyQMgBzxbLpzMhG5fIMc5MjgUSkV77Ul9d3vw9GSrVbpzKMwK3Rcqs4T/kA0kppvF5O g57gXsjUHHU+i611ITDnh8JYOg0L7NCNKNeytlNE+XJkJ1+XnTUQVLogBXU78jNj8tm9wDSXv X-Received: by 2002:aa7:d053:0:b0:43d:b75:fd96 with SMTP id n19-20020aa7d053000000b0043d0b75fd96mr22459401edo.12.1660063986630; Tue, 09 Aug 2022 09:53:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5gzkJBjXi5JrgZvQh5pT4q6/Bw59Zd7ee6LK0+o+q8GfZVYN/lsiKLqPX9zOQUdHlYif150A== X-Received: by 2002:aa7:d053:0:b0:43d:b75:fd96 with SMTP id n19-20020aa7d053000000b0043d0b75fd96mr22459380edo.12.1660063986249; Tue, 09 Aug 2022 09:53:06 -0700 (PDT) Received: from [192.168.109.187] (static-84-42-168-254.bb.vodafone.cz. [84.42.168.254]) by smtp.gmail.com with ESMTPSA id la19-20020a170907781300b0072f0a9a8e6dsm1285228ejc.194.2022.08.09.09.53.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Aug 2022 09:53:04 -0700 (PDT) Message-ID: <8c536717-a252-726e-102f-2124dec23030@redhat.com> Date: Tue, 9 Aug 2022 18:53:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PIING][PATCH v4 00/15] Clean gdb.base when testing with clang To: gdb-patches@sourceware.org References: <20220720194441.168906-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: <20220720194441.168906-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 16:53:12 -0000 ping! On 7/20/22 21:44, Bruno Larsen wrote: > When testing GDB with clang, gdb.base had over 50 more failures than when > testing with gcc. Examining the failed tests led to a few clang bugs, a > few GDB bugs, and many testsuite assumptions that could be changed. > > After this patch series, nothing should be changed for testing with gcc, > and testing with clang should only show non-trivial failures for > maint.exp and macscp.exp, along with the same GCC failures. > > Changes in v4: > * Added new test to step through a function's epoligue > * renamed gdb_step_until_regexp -> gdb_step_until > * small style and wording changes in patches 1 and 2 > * Dropped patch 3 - no longer necessary > * patch 4 was reworked based on Andrew's suggestion > small note, Andrew has OK'd patched 5 and 6 (currently 4 and 5) in v3; > > Changes in v3: > * Fixed some issues that only showed up on CXX_FOR_TARGET=clang > * rebased on current master > > Changes in v2: > * Introduced gdb_step_until_regexp, based on Pedro's and Andrew's suggestions > * reworked fixes for: skip.exp, skip-solib.exp and msym-bp-shl.exp > * Used Pedro's suggestion for call-ar-st > * reordered patches slightly > > Bruno Larsen (15): > gdb/testsuite: introduce gdb_step_until > gdb/testsuite: Add a proc to test where compiler links the epilogue > Change gdb.base/skip-solib.exp deal with lack of epilogue information > gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang > update gdb.base/info-program.exp to not fail with clang > fix gdb.base/access-mem-running.exp for clang testing > Fix gdb.base/call-ar-st to work with Clang > add xfails to gdb.base/complex-parts.exp when testing with clang > gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang > explicitly test for stderr in gdb.base/dprintf.exp > gdb/testsuite: Update gdb.base/so-impl-ld.exp > [gdb/testsuite]: fix gdb.base/jit-elf.exp when testing with clang > gdb/testsuite: fix gdb.base/info-types-c++ with clang > gdb.base/skip.exp: Use finish to exit functions > gdb/testsuite: Add test to step through function epilogue > > gdb/testsuite/gdb.base/access-mem-running.c | 2 +- > gdb/testsuite/gdb.base/call-ar-st.exp | 13 ++- > gdb/testsuite/gdb.base/complex-parts.exp | 5 + > gdb/testsuite/gdb.base/dprintf.exp | 10 ++ > gdb/testsuite/gdb.base/info-program.exp | 2 +- > gdb/testsuite/gdb.base/info-types.exp.tcl | 109 ++++++++++++------ > gdb/testsuite/gdb.base/jit-elf.exp | 2 +- > gdb/testsuite/gdb.base/msym-bp-shl.exp | 8 ++ > gdb/testsuite/gdb.base/nodebug.exp | 12 +- > gdb/testsuite/gdb.base/skip-inline.exp | 23 ++-- > gdb/testsuite/gdb.base/skip-solib-lib.c | 3 +- > gdb/testsuite/gdb.base/skip-solib-main.c | 3 +- > gdb/testsuite/gdb.base/skip-solib.exp | 12 +- > gdb/testsuite/gdb.base/skip.exp | 32 +++-- > gdb/testsuite/gdb.base/so-impl-ld.exp | 13 +-- > gdb/testsuite/gdb.base/solib1.c | 5 +- > .../gdb.base/step-through-epilogue.c | 15 +++ > .../gdb.base/step-through-epilogue.exp | 86 ++++++++++++++ > gdb/testsuite/lib/gdb.exp | 62 ++++++++++ > 19 files changed, 334 insertions(+), 83 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.c > create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.exp >