From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tdevries@suse.de>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by sourceware.org (Postfix) with ESMTPS id 129B438582A2
 for <gdb-patches@sourceware.org>; Mon,  4 Jul 2022 19:45:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 129B438582A2
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3A1ED1FF03;
 Mon,  4 Jul 2022 19:45:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 213D31342C;
 Mon,  4 Jul 2022 19:45:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id pHhaBmlDw2IVSgAAMHmgww
 (envelope-from <tdevries@suse.de>); Mon, 04 Jul 2022 19:45:45 +0000
Message-ID: <8c6ba70f-305d-c3ed-591d-36f1f38d52a6@suse.de>
Date: Mon, 4 Jul 2022 21:45:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH 3/5] [gdb/symtab] Work around fsanitize=address false
 positive for per_cu->lang
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
References: <20220629152914.13149-1-tdevries@suse.de>
 <20220629152914.13149-3-tdevries@suse.de> <8735fgvie4.fsf@tromey.com>
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <8735fgvie4.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE,
 SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2022 19:45:47 -0000

On 7/4/22 20:32, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom>  /* The number of bits needed to represent all languages, with enough
> Tom>     padding to allow for reasonable growth.  */
> Tom> -#define LANGUAGE_BITS 5
> Tom> +#define LANGUAGE_BITS 8
> 
> This will negatively affect the size of symbols and so I think it should
> be avoided.
> 

Ack, Pedro suggested a way to avoid this:
...
+  struct {
+    /* The language of this CU.  */
+    ENUM_BITFIELD (language) m_lang : LANGUAGE_BITS;
+  };
...

Thanks,
- Tom