From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A59323858D32 for ; Thu, 6 Apr 2023 00:17:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A59323858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.170] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C16671E0D2; Wed, 5 Apr 2023 20:17:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1680740227; bh=XNXjBME7iD5o24AG1Beh3mKk0J1ymL9VTz9PNn4Gl8E=; h=Date:Subject:To:References:From:In-Reply-To:From; b=CmjDcoqptrqSFWzipZrf2nAZ8hgcu93yDop1lzAETm1u2vCHehK6HjuDgS+ZoDL+b EvBflQ4lXYo3ke5HS63WA/eyYki0HJhLxf0SSfVC9KZ8zKgu0WS1kBnnvkBXqd2YMR 7XFaNAEBi/jl39p+DZiowyMNujE5XiwwcbM+QD9Q= Message-ID: <8ca29409-2a43-c4a1-ebbe-02ae519b79e4@simark.ca> Date: Wed, 5 Apr 2023 20:17:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] [gdb/testsuite] Add -q to INTERNAL_GDBFLAGS To: Tom de Vries , gdb-patches@sourceware.org References: <20230405183410.13468-1-tdevries@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <20230405183410.13468-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/5/23 14:34, Tom de Vries via Gdb-patches wrote: > Whenever we start gdb in the testsuite, we have the rather verbose: > ... > $ gdb > GNU gdb (GDB) 14.0.50.20230405-git > Copyright (C) 2023 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > Type "show copying" and "show warranty" for details. > This GDB was configured as "x86_64-pc-linux-gnu". > Type "show configuration" for configuration details. > For bug reporting instructions, please see: > . > Find the GDB manual and other documentation resources online at: > . > > For help, type "help". > Type "apropos word" to search for commands related to "word". > (gdb) > ... > > This makes gdb.log longer than necessary and harder to read. > > We do need to test that the output is produced, but that should be limited to > one or a few test-cases. > > Fix this by adding -q to INTERNAL_GDBFLAGS, such that we simply have: > ... > $ gdb -q > (gdb) The license text never really bothered me in gdb.log, when I consult gdb.log I usually search for some string, so it just skips over that. Not having the license text makes it a little less obvious in the log when gdb has been restarted, so that might be a bit more confusing. But otherwise, I don't really mind your change, I'll get used to it. Simon