From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111795 invoked by alias); 3 Jan 2019 05:09:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111660 invoked by uid 89); 3 Jan 2019 05:09:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=BAYES_00,BODY_8BITS,GARBLED_BODY,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Jan 2019 05:09:21 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x0359FhP019405 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 3 Jan 2019 00:09:20 -0500 Received: by simark.ca (Postfix, from userid 112) id 605FA1E7B1; Thu, 3 Jan 2019 00:09:15 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 681C91E4C0; Thu, 3 Jan 2019 00:09:08 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 03 Jan 2019 05:09:00 -0000 From: Simon Marchi To: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_=D0=9F=D0=B0=D0=BB=D0=B0?= =?UTF-8?Q?=D1=83=D0=B7=D0=BE=D0=B2?= Cc: gdb-patches@sourceware.org Subject: Re: Don't build readline/libreadline.a, when --with-system-readline is supplied In-Reply-To: References: Message-ID: <8cb2cddc50577d82422176d1ffebe140@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00056.txt.bz2 On 2018-12-12 02:46, Дилян Палаузов wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=18632 > > The bundled libreadline is always built, even if the system is > ./configure'd --with-system-readline and the build libreadline.a is not > used. > > Proposed patch: > > Fix ./configure.ac not to proceed readline/, when --with-system- > readline is provided > > diff --git a/configure.ac b/configure.ac > index 159f968..adf6dfb 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then > noconfigdirs="$noconfigdirs zlib" > fi > > +# Don't compile the bundled readline/libreadline.a if --with-system- > readline > +# is provided. > +if test x$with_system_readline = xyes ; then > + noconfigdirs="$noconfigdirs readline" > +fi > + > # some tools are so dependent upon X11 that if we're not building with > X, > # it's not even worth trying to configure, much less build, that tool. Thanks. I've tested it and pushed it (with the generated configure and the matching ChangeLog entry). For those who wonder, Joseph Myers suggested we take care of this patch in GDB and then sync it with gcc [1]. Simon [1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00299.html