From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16775 invoked by alias); 9 Sep 2017 19:11:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14083 invoked by uid 89); 9 Sep 2017 19:11:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 19:11:56 +0000 Received: from ESESSHC009.ericsson.se (Unknown_Domain [153.88.183.45]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 24.B0.21299.9FC34B95; Sat, 9 Sep 2017 21:11:54 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.45) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sat, 9 Sep 2017 21:11:53 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [192.168.0.102] (80.216.43.226) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.4; Sat, 9 Sep 2017 19:11:51 +0000 Subject: Re: [PATCH] Introduce gdb::byte_vector, add allocator that default-initializes To: Pedro Alves , Simon Marchi CC: References: <1497287225-16542-1-git-send-email-palves@redhat.com> <09d8de02f155c73bb3d04c9589589327@polymtl.ca> <583dd599-bcb3-d729-9b79-4dd9ccb26121@redhat.com> <975b9c0aac917b6954d9dffd0438de82@polymtl.ca> <78076de1-a317-3e38-8529-63824943e3af@redhat.com> From: Simon Marchi Message-ID: <8d187d70-b45a-7336-190b-cb8e7ad47b4b@ericsson.com> Date: Sat, 09 Sep 2017 19:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <78076de1-a317-3e38-8529-63824943e3af@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HE1PR0202CA0046.eurprd02.prod.outlook.com (2603:10a6:3:e4::32) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bd3926f-fc7c-4517-f597-08d4f7b6a0ab X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;3:O7Vhgmh0Rgr4qih7D9otQ7gAf0hxDOFdLBkTa7F541M1pZsOGbeRqh+0Hjy5HQPikG7qVfChNlNhQ6f4JtNSYlhcp50aAcexBhP0AeCVKEZBZrQd3WLuNrR36cQykNpfzddz+JU8RBscM71KlvsFVmWdf0d+F9ahbMvj389c7nl1iFzuifhwy8cMTwUhGAvBAjjCP2zruGbaMWni2xGir0Xbzj+/Av4IfLcagB9mKvmU8v3w5W3UX2eoj1pf+9je;25:bCbFR+jwE9z5YZozBRJ4FIxwG6FUDDSsClTclX1oPZsIaZRLOKSaWYCdB+d0gQAOiYIZqrFUBxA3jmY8vNtCO/vKyhTANv/KS8a3X+3ftqD2j7xdK1q2jOaN7IR7fAf1WHGoUxvVRyp9XePq0bYjgCTycq8y51ehTrs0LARUeaIiUvWRo8OzLO0FAPRl2tshl8MCVgjJTACKGG2AMicI8qVXrigzer9D3O7ZXfOagBiO9Be+wgXn4C5RcIr7M//k0MMtL0uQ7oFPzAJVb33is1RFT49HcZiN9WN1AComuXq3w/cuI0vcbb31uvdWgrqv9jH9yjrapBQMZkHjejRdqw==;31:/1bh7DFmjvcDES6fjY3Ufdt/zxpo7B3aK3/7K7aWMiY0TYh5mND3lBpMgl01+Vf1H5XAHSukYGgyUbXx7/4PRPD0ATEMYueKu85rh+u+3owxFMvuxmJI+nxMEyNHrEHXLV2JrTMCh/YoDG3+P0xwjNmJtvNwRbJFAhry900lXir7BDNqs5VOBsQMr9mtrnIiSBRPPbbQsU0AXqw84o85glMzqsv2mceewhjNpBwueww= X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;20:k9bevz+wwnpl2udVmPIblFTE4hKk6zFGAGHjkZklRhtWztgBFIf1G6zuGoh4YC+9vXIPcw5LUVJ7RdJZ0O9JBjNyGo/DDKAHWyTfi6aQFIAJOpgGcgzpvqKD8TTImUpWNke7dtZMGyEdGokp/wOLgbVykaZKnoISW/eBQql9U5nYiXcR0Gm2W4S3sLle2zroj5b+bz13vO5gSV5enYHsU3w0o1U3CEwsrHKKW2bVvkqhma0jI1T27tbpxWJrAWwQdizW9t8H5UeOAREG00YuJpYlQGsAkq0U9eeeb294aG4IPLViG4ZTaven8WLXiNQuDRHjNC52egGjeC8PAijhNTk3i2vZOXe2minFJ4FTNbV+0nBY9/jmmYEql1k/Zh3Rql+akBRbzvxXRoUH/gZ1b2U9lZqRmf/hWNEt+nC0V2YXjeAK1ybUlsn/V8bv4YJOfZyCc02tCZ2xmCEEkNq+KUpAqfXTPh5l2ENbGHtcgJqmquFKgy/LBUFTAMqCb4bX;4:7D6hphiRnxc2tx1KvieMN7ViN/NvhVQqihY1SyrROBqYfxazjTVzzp2WEcHa75cMURP/Ntz2P7Y+7c7FiKljZztUoe+UgMUpwlogT9ouqV6WTzpCF97l7nAJnvgaoY+OgjzldeQQAstI43Ao/5d49alf29wdyUnGb5ht0qMJo+VxTvxC3zMIw7meZ1L/zxrzCUP/GeaeXzppxGqbmTK5TiQRVTmykH1LQBqDEKNM5Z4Gx58sewOiHG1dCU4U98aM X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB320;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB320; X-Forefront-PRVS: 0425A67DEF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(7370300001)(6009001)(6049001)(189002)(24454002)(377454003)(199003)(377424004)(51914003)(4001350100001)(97736004)(101416001)(42186005)(53936002)(117156002)(50986999)(8676002)(305945005)(54356999)(76176999)(47776003)(7736002)(33646002)(6666003)(64126003)(2950100002)(189998001)(230700001)(81166006)(68736007)(81156014)(93886005)(105586002)(106356001)(53546010)(65826007)(5660300001)(86362001)(7350300001)(3846002)(6116002)(31696002)(6486002)(50466002)(36756003)(77096006)(65956001)(66066001)(65806001)(23676002)(6246003)(478600001)(229853002)(25786009)(31686004)(83506001)(4326008)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB320;H:[192.168.0.102];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMjA7MjM6KzZESHVnME1Zb2Q0NVpMeUd2aGtPdkp5RjNr?= =?utf-8?B?OW50d2s1RUpTWE11eGZPZERNcXJNMDZsV3JCVEVnUVNoRnFLRURmM2ZONFJr?= =?utf-8?B?OVV1QzllTXA5UzRuZnF3TENSOEZ6VDRKcFZFSklpOHh3bXpEbGM4MitPdm02?= =?utf-8?B?NVMvQWd5SkhpcXNlRXBTYUU5UGsyWVdJK1V0cnNtdVRlYnhTRnlWVWxQUzRs?= =?utf-8?B?K3N0c2tCSVNlRmFNRXRZbHptQWY3ekhBVDBNbjVTZHVDNStYOVRZbXJMNHZq?= =?utf-8?B?QlkwOVhmVXJqb1VWTHRNTmlmUTMvNDNtQkMvOHR5bmRKdnN4T3U3SzNxWmlp?= =?utf-8?B?VXVUallQQ2w3ZmpUNWs2SEtPT1pYTGIxKzlGMEM3ZG1BTzVHaHgwdFg0bU1x?= =?utf-8?B?ajBsU0RTbDFEUDVsNll1WFJvY0UyZ05Pc3kyTkFVdFpPd1ZJakZLRXJiSVdq?= =?utf-8?B?M2xtU2U2c3A0TER0Ukh0ZDd0N1FXZ0JzcStOc0pnR0pHVGNiL0kvMDAvVjcx?= =?utf-8?B?T2wzdUY3ajY4alNwR2Ura2NXYzI2QUtlblIrZ3QyNlIyOUlUTUlKTE1NU2Q1?= =?utf-8?B?VVhpV0k5aGpWcWh2TEsxK2VmaXc4b1JDZ21OcTRua1FqR2VkSW52NlBrTVpz?= =?utf-8?B?SzBmSzlKRURnaHJHMTc0Tkw4RWRscDlrWE8ySUJkdUh0UE92bEhabmw3TzY4?= =?utf-8?B?elMzZjJSSU5rdTA5M0hDamRDTXNrVlZOZ01vdXVSbnV0YlB2cnMwVmRTM0k1?= =?utf-8?B?d2w1V21xVXNEVG1LR04rMG1DeUdqUVZaaVFXaHdja1ZkMW01aFo5NTVtUDJW?= =?utf-8?B?dS9hRDFMZEg4RlNILytORlk0eFNzR0VGTEhOczV6YXg0bXFacGxuVnhzQUNV?= =?utf-8?B?eUpQOW5UTEFMQ1ZWTjVObU1NYndvTTJTdDJ1Uys0aGtsMnJJTzZWKzZnZUtp?= =?utf-8?B?VHdaRDRQQXlDRkdkdk5WaElpa3Uwdm5IZGt0aUZoeTFXQyt5MWpLd2szVkg4?= =?utf-8?B?UXJ4M0VmVWRKZXhWSDZ5SmFVaEh5Wnd6Zys2VFBZKzRuamw2cEMzdG1NZ0RO?= =?utf-8?B?bitEZkJzS3FSdDJzeks0bmR1dWsvNHo4aThEMzNsY2NLVHZPR2RlYnR2bmFB?= =?utf-8?B?ZkZTeEhpd01Ebm54Vm00aHV0RFdqR2JOZklYT2JZNGVRenhOVlpjT1BiaFVr?= =?utf-8?B?UVJmMHl4eXVDT2JHd0xuTklpNjFVVzdUNWYwSUVBdVgxZ1d2dUJEbkNwSmJ3?= =?utf-8?B?TXFNSC9udnVVU0sxTUYvOU9jVWhOWEFLQWt2Y2lhZExScTY3TXA2Z0tSUVFM?= =?utf-8?B?L01HMGxzZG9jR1orTk4rVU0zS083eUVZLzBvNWdsZFgxNjNuRUNZUDZBVXlJ?= =?utf-8?B?T2Q0OVFCa1dwT1JESStCV1J5YVRPdHJFVklCOEwrWldQdlVUVHNPbi9EZGVK?= =?utf-8?B?Q0RMZ2t4bEdldUlNTmk2Uk53Ly9rb3ZWcjJSR3pPd0hNSWN2eEpJOWN1NXlH?= =?utf-8?B?ZUlyM3lsSExKRHdpRWluSkdQS1libUUraGQxR1N6UTNDc3owUlY4S1FMTEQ0?= =?utf-8?B?dDZPLzV1UmZJdUlNVXVZcXNqYjNnaHFBZ3VFMFlnUUQ2c0JlTVA2YlpBbkJi?= =?utf-8?B?MXAxTkFKTUQvTnAwMXVjdmYxM1NLeW01dEhKaTJILzNwS2ZJVi9FbVdRUTND?= =?utf-8?B?K084QzhCN2hjVVo1d3JDT3pvYVRpMHlhT20vRUZsSGRnTTdvdUZUSVJGWmt6?= =?utf-8?B?S0JWN3FOUVBiNStSZ1dmTDZrSGxOZSs1RW1YZVRqUUNTRkZaMjVQU1RwZ1Zp?= =?utf-8?B?NmhoUTRRZTJZQlFZSU9oRjhIVGQvSk5uS1hWMC9FM1drOTFTWG5vdVVwK21Q?= =?utf-8?B?bmV3cEE3cHM0OW15QkYwL1hBVzRUcStBTkRaWDAvUnZVYnZtR0FuOWNjMVNo?= =?utf-8?B?Mm45cllYNWc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;6:x9+9vNJoUcOuWgPsrxwVBX6qv5DuXgMQ5Il95lpQE++3HqcYjMCUEEUTVAGEyVdBiNjJNGQc//7yJgKM76UF1q8Nk61NAP+V1UTV5I6DYxWA9zTR2lPbseZ6kbACNdUHRdkk9tyR4ZJSsuJqqBfC4nLuRDFGFimeoRwWiN3i3V1XMBFxb13mxebkASVj3yTpVi6f4+2DysdXl2p7yGg+3RHUfEwo7j0Z4DiOmewNC52W/+ccXEU0gWYhAkvTXe7yimeNI0yVrWVeN1mtNnzZSCrX0U0SZIyhIbMVVYGlSSZRS7EOBtQIL9K2pWiQIUZYHeoKBFBXHnn0+KTu7rlUYQ==;5:Rv6hgMB01HnG2FcNwKzbgj1Pvh1xyVYah3+2Mi+mcGY4Eq3DaqjSTtVxK6jBzYFewfExCZeo5tP4cjzOROmLR8vAggyLy1qH5pFs4nlLKcUOuovlEA4TMtar+znWMsnx5Ky6N4JZRo3FFffWpw6UvA==;24:L4QFYpAZ1ZBV2rG826uMVRZJHCWs9F0JUU/iBrd1wopfKUhMe9HucRGcni0d8tNqkgavKELRqP2+X6HRYvCk9yOB2X5SY9wMAyK5ve1pg4s=;7:Xw3N4Y6Ugkc5fSNc5+W+I+scjrEGggkW+7qZNdTea8HJdxHAmRLhta5hFmPss0FKr7veRAAFYRxKJZIjJaam4mdsVK/r/Jeh9n1KDtgaMm16LGkd4PA+/n5u0nFFpLp9qlNs6NT1dXQHZJNK/y5DP4lZAt0NZBsz6A1UssTJrKjicpHrynVNIc31jU7mTFNQQmcsr01OAkZNwzAdwkeTARefbsxDZ38UQt/o1YG1wJE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2017 19:11:51.4377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00254.txt.bz2 On 2017-06-14 12:21 PM, Pedro Alves wrote: > On 06/14/2017 09:39 AM, Simon Marchi wrote: > >> Thanks for the detailed explanation. It's all very logical, but it's >> also full of small details essential to really understand what's happening. > > Yeah... As custom with "library" code, thankfully uses of the types > can remain oblivious to how the types work under the hood. > > I've pushed the patch in now, with the trivial adjustments to both > dwarf2loc.c, after Andreas' series, and to make the new int128_t printing > code use gdb::byte_vector. Hi Pedro, I am looking at Tom's recent patch that uses def_vector, and I am wondering if there should be a check somewhere to make sure we don't use the default_init_allocator with non-default-constructible types. Let's say we use def_vector with a trivial type, and then we later decide to make that type non-trivial by defining a constructor. It looks like it would still build, but I suppose we shouldn't use that type in a def_vector (for the same reason that we shouldn't allocate it with malloc). It could easily go unnoticed for a while. Simon