From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 01EE1395A023 for ; Tue, 31 May 2022 14:47:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01EE1395A023 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id r123-20020a1c2b81000000b0039c1439c33cso1339583wmr.5 for ; Tue, 31 May 2022 07:47:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BMwR+SmP8KvnBl9K07DueNh/lzUXvr+RAC0d0xXx/TE=; b=QsTdRmqRzb+P1omJ/gKCc/8qqCmt8zVyCZIKGlgTosCYqLYUsK0PQcwApHQi/C5i/Z rK8pabQmeSAKJu47QaE/8WIkQcFbaMubgFDH6kpPa16q1/hFNuRGzMsOzmjey9rNld7h sp2E1J3qaQazQN8AWibs2WDfG+dY4nWgt8ea4MxYrrv1D4I/Fj2ovzl4+/0jI2iEyLEF KXSizO5+pjnWF+Cjmjd8qwaghx5sHCu9esdV2cDs51l6saYK0hKyWJe3w+f67B0OU9ZV RpkWwcwVbaL4jbqs/tdPyvfO5hP9iFKH4Wd9zPnXW/dQBuYKq2x+rgwfAs3PE3vCfQfx PJww== X-Gm-Message-State: AOAM533F40cWiBmOqlNGwRw5AFXHF6U9xdh/PMKIkaMFnUj4aSlt6Lki o3Mch9+o31sqv0+mzEN80aC79xTcfcQ= X-Google-Smtp-Source: ABdhPJwa27BWn0TEQUxLx5GmqYr8SL9pBgvVF5EkrzlBs2ggnfsSc2bdKAERVrc+D55X0m9DUKxVsg== X-Received: by 2002:a7b:c143:0:b0:397:4d12:244c with SMTP id z3-20020a7bc143000000b003974d12244cmr24719643wmi.29.1654008442872; Tue, 31 May 2022 07:47:22 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id w9-20020adfee49000000b0020cfed0bb7fsm11927096wro.53.2022.05.31.07.47.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 07:47:21 -0700 (PDT) Message-ID: <8d188138-0820-7276-9e9f-c80be6f82237@palves.net> Date: Tue, 31 May 2022 15:47:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] Improve clear command's documentation Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20220526194250.2310460-1-pedro@palves.net> <838rqmm7gb.fsf@gnu.org> <6914f754-4e33-5aa1-4ea6-dca9504e8bfe@palves.net> <837d63j8tx.fsf@gnu.org> <83k0a1j2ur.fsf@gnu.org> <3c77c9b4-9984-0a71-c6fc-04fc707b6b07@palves.net> <83fskpizsu.fsf@gnu.org> From: Pedro Alves In-Reply-To: <83fskpizsu.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 14:47:25 -0000 On 2022-05-31 14:42, Eli Zaretskii wrote: >> Date: Tue, 31 May 2022 14:04:00 +0100 >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> >>> WDYT? >>> >> >> I like this a lot. Will you merge it, or shall I? > > I'd prefer that you did, if you don't mind, so that all the changes > would be together, or close. Done. Just with one small tweak -- your text used wording that assumes a breakpoint only has one location, "deletes any breakpoint whose code location is at", etc. I tweaked it to say "any breakpoint with a code location that is at", etc. If you have a multi location breakpoint, and you specify one of the locations, gdb really deletes the whole breakpoint: (top-gdb) info breakpoints 3 Num Type Disp Enb Address What 3 breakpoint keep y 3.1 y 0x00000000000ed06c in main(int, char**) at /home/pedro/gdb/binutils-gdb/src/gdb/gdb.c:25 3.2 y 0x000000000086aa66 in selftests::string_view::capacity_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/capacity/1.cc:167 3.3 y 0x000000000086ae85 in selftests::string_view::cons_1::main() at /home/pedro/gdb/binutils-gdb/src/gdb/unittests/basic_string_view/cons/char/1.cc:62 ... (top-gdb) clear *0x00000000000ed06c Deleted breakpoint 3 (top-gdb)