From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id CD7083853551 for ; Thu, 9 Jun 2022 15:40:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD7083853551 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id u8so28620021wrm.13 for ; Thu, 09 Jun 2022 08:40:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=NP9r4fFXSWYrjtztXYcaQTnmJsbBXl4BrEccxZDql7c=; b=nSeMwqbcsPFhM04wQlJZz+b5YGiEuktnDjya8HcpK/f8A+Gk0YUTV58RpVs2Z4pF6a P7ici43vYe7L67aGIlkZ6aBhOwt617ziFH02rppi+jw+X3xe+lfuzeY72cJf2hmy2uWQ ely9ZDj6Sbz0BaQJl2U8ZbGlFUh/CVkcPIsma8/EK1Ip9CMx8BDbVw7AMDKxpm1/sgXb L6ClRwlua9PXYlR1OSd3xZkoMmUtvb/RwWiDUPJmxCL8WeMZXyZltj5ajR8Ho+o3v/Oo TJWVL4ieQgMcT71e/5lSrQcJ3JTuB3dLr7r1UgPnSLWZJp+c+i+QkYYXhG+Ly7z5qhms 5IGA== X-Gm-Message-State: AOAM532iXAnQ9R5SFIizCI9gl3cg7NbIXkp4awq30JZ3NlStxlLCj7/x m/ycrpXJ9a78oOYrsJL80H5H9iFVYaQ= X-Google-Smtp-Source: ABdhPJyxzq/C38EZ5l3iupV0Sbi6VLJ9uuyy4EY73pD2emyXAP0h+5njIhBb1PFEZ0Va5OVaXgvy1Q== X-Received: by 2002:adf:f752:0:b0:210:17da:f9a7 with SMTP id z18-20020adff752000000b0021017daf9a7mr39269646wrp.398.1654789224713; Thu, 09 Jun 2022 08:40:24 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id o14-20020a05600c378e00b003974d0d981dsm30662807wmr.35.2022.06.09.08.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 08:40:23 -0700 (PDT) Message-ID: <8d25f1c9-d4fe-7eca-e3fc-1840482fb914@palves.net> Date: Thu, 9 Jun 2022 16:40:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] Allow 'interrupt -a' in all-stop mode Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220608152754.1369001-1-tromey@adacore.com> From: Pedro Alves In-Reply-To: <20220608152754.1369001-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2022 15:40:27 -0000 On 2022-06-08 16:27, Tom Tromey via Gdb-patches wrote: > PR gdb/17160 points out that "interrupt -a" errors in all-stop mode, > but there's no good reason for this. This patch removes the error. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17160 The code change in GDB is OK. The testcase part, I'd rather this wasn't done in gdb.base/interrupt-daemon.exp, as it's very unrelated to the purpose of that test. I'd rather a new testcase called, say, continue_-a.exp.