From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 37D9C3858C78 for ; Mon, 27 May 2024 21:26:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37D9C3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 37D9C3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716845187; cv=none; b=mEnH5Q6eiIFiS8CuEeRLobGlPacSwRaaYufeAM0cMQDv7UFF2M8jue6xGqITtAiuiJYbVS9Xc+QHMMt/nX0pDJZjgzvOub1iNPJIzRpSWNh/+TYB/oiiiY/u0RFFD/IHS0U2CTHNVKV4BGFFfWqWS02T2X3qnPwgPdCgT371Eig= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716845187; c=relaxed/simple; bh=S1lIEWgMDD4r3EYCb8RhL0uYmlakbnUk6blIvZFqALw=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=HRjAkNfE/gK4weMBAu2ZQDgTS11OuEBxdzj+Gln9efpGjgvDdzJVbKBEWZy08m8lgTjbpFHcPLE5S9d1PvgfiqIfB6QmiJrIdCatMLrRDANV88aeFNZ7hWIFvZx/0u149GdF5uK1WVaoeZvdgxHJFt5iXjnuKaECA+qUEbkz4DQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716845184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gbQKim3x6FiJ6TLx0IaeOItGj7e0h4E6rsIPlYCZIf4=; b=HnfEynC9J+Jl73OUiqIthuh1nJ7AfSm8psKvQnQt+vMt0sZ4Zf/CzRlo0uRLFSDvn4+E5x 9StMoa1bIERCReWXodDVhfndyclmK5Y3L8g5MKgL5cX3HkoUftVWalnH2nJt3fCLOaQ8Rz jEZeVQ/PlZoeoswtckrMJPEKYmjBykk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-YWvXOgDVMhibFyg0YMc7-A-1; Mon, 27 May 2024 17:26:23 -0400 X-MC-Unique: YWvXOgDVMhibFyg0YMc7-A-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-357bcbedd25so75098f8f.2 for ; Mon, 27 May 2024 14:26:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716845182; x=1717449982; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gbQKim3x6FiJ6TLx0IaeOItGj7e0h4E6rsIPlYCZIf4=; b=A6Tj73hAmTPgPgG6Mn9qt94T3JD8P0jsVUEEsjqYHNrniughjuxg81lpPetTWs+iz7 AvL3fw/0DCFWRveAPrGoVF+LnurNu2ixNF/gs7qIxJxRQniXNciOPnB7l2QF6pj7Y+jF RJlQQ2euZ5HVRfIaE+ny0LzUCO42lUM88mY5isamIKWjKnWWHxVR7v0v7ijnsBIa8i8j PpL85NHbg613wzCHgOFpNP+S0MckbRQfTYrB2P7SZfyHwd6sSwitHassBk59g1HeGE71 YTNIXeQZNFMqkH57UguUjr8OsconWR8VHumFfsU36zPaFV/whaQpkgIqCPQcHQCFT6wx 4Lxw== X-Gm-Message-State: AOJu0Yztzsp3q1aTVUaaEb0eP28pFxxxtMGb6TwvX+wgi9h94hMCF7J/ h/q0WBYC4YKcFb1o9tSOn5nogkqNJePKCmT2+JhDUOngIeZlVkTCc5v38pif4FgjQiNaPOHSpMx T9HYV/PB4mPS/rvwCvBl8OPvNafZYH9ERHq/X2zxBXwjs+8vyxbEtSK4xQ2M49yVHjAuBvcBI09 X9D8+PLczYOe5YIHGo6CWgxRcpCGew5KDJVqpjBO9gwkI= X-Received: by 2002:a5d:5452:0:b0:354:eb32:6d1a with SMTP id ffacd0b85a97d-3552fe020c4mr6353038f8f.59.1716845181998; Mon, 27 May 2024 14:26:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7BrE379kD+fCAGdBNHd5f839TAWCNSqCRhzdt5I+vwPo4d2a5SPXMcX8aZYG+zuKQJKeWAw== X-Received: by 2002:a5d:5452:0:b0:354:eb32:6d1a with SMTP id ffacd0b85a97d-3552fe020c4mr6353027f8f.59.1716845181348; Mon, 27 May 2024 14:26:21 -0700 (PDT) Received: from localhost (host86-153-169-45.range86-153.btcentralplus.com. [86.153.169.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3557dcf03acsm10094377f8f.103.2024.05.27.14.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 14:26:21 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb/testsuite: fix unresolved test in gdb-caching-proc-consistency.exp Date: Mon, 27 May 2024 22:26:10 +0100 Message-Id: <8d696883107c9d3b44aa35ee92d1d5199a12f93d.1716845155.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running gdb.testsuite/gdb-caching-proc-consistency.exp with the native-gdbserver board, I see an error reported: ERROR: gdbserver does not support attach 2036113 without extended-remote and a test is reported UNRESOLVED: UNRESOLVED: gdb.testsuite/gdb-caching-proc-consistency.exp: testcase '/gdb.testsuite/gdb-caching-proc-consistency.exp' aborted due to Tcl error The problem is that we are calling the can_spawn_for_attach_1 caching proc directly, rather than through the can_spawn_for_attach wrapper proc (which is not caching). To fix this, in gdb-caching-proc-consistency.exp, I did consider having 'test_file' spot 'can_spawn_for_attach_1' and test 'can_spawn_for_attach' instead, but that runs into problems as the 'test_proc' procedure does expect to be calling a caching proc, not a non-caching wrapper proc. I could make 'test_proc' smarter, but in the end I just opted to replicate the condition checks from 'can_spawn_for_attach' inside the 'test_file' procedure, there's only two of them, this seems like the easiest fix. If we end up with more cases like this then it might be worth restructuring things in here to better handle wrapper procs, but for now that doesn't feel necessary. --- .../gdb.testsuite/gdb-caching-proc-consistency.exp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp b/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp index 572ffb526ba..5312b395283 100644 --- a/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp +++ b/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp @@ -91,6 +91,14 @@ proc test_file { file } { "target_is_gdbserver" { set setup_gdb 1 } "supports_memtag" { set setup_gdb 1 } "have_native_target" { set setup_gdb 1 } + "can_spawn_for_attach_1" { + # This replicates the checks found in + # 'can_spawn_for_attach'. + if {[is_remote target] \ + || [target_info exists use_gdb_stub]} { + continue + } + } default {set setup_gdb 0 } } base-commit: bdc10cded85aa8995e80394099c9e542b6172979 -- 2.25.4