From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101683 invoked by alias); 31 Jul 2017 19:42:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101621 invoked by uid 89); 31 Jul 2017 19:42:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Jul 2017 19:42:34 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v6VJgSZH024128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Jul 2017 15:42:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 2C6D61EA05; Mon, 31 Jul 2017 15:42:28 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id DCCCA1E5B1; Mon, 31 Jul 2017 15:42:26 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 31 Jul 2017 19:42:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA v2 15/24] Use containers to avoid cleanups In-Reply-To: <20170725172107.9799-16-tom@tromey.com> References: <20170725172107.9799-1-tom@tromey.com> <20170725172107.9799-16-tom@tromey.com> Message-ID: <8d7bddd8b82901b2147a1774f0bd04ca@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 31 Jul 2017 19:42:28 +0000 X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00455.txt.bz2 On 2017-07-25 19:20, Tom Tromey wrote: > @@ -601,24 +599,16 @@ elf_rel_plt_read (minimal_symbol_reader &reader, > OBJFILE the symbol is undefined and the objfile having NAME defined > may not yet have been loaded. */ > > - if (string_buffer_size < name_len + got_suffix_len + 1) > - { > - string_buffer_size = 2 * (name_len + got_suffix_len); > - string_buffer = (char *) xrealloc (string_buffer, > string_buffer_size); > - } > - memcpy (string_buffer, name, name_len); > - memcpy (&string_buffer[name_len], SYMBOL_GOT_PLT_SUFFIX, > - got_suffix_len + 1); > + string_buffer.assign (name, name_len); You can get rid of the name_len variable and just use string_buffer.assign (name); Otherwise, LGTM. Simon