From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0A9B93858D28 for ; Fri, 22 Dec 2023 17:06:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A9B93858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A9B93858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703264765; cv=none; b=KmcbfG+F1h1Jm5tPJK4vPmkOZiE7BTJ+d9ELphoJalwW3l9snRc4cngsWUsw2DpNsQ18PKYG9pPwgOav9pnXYTPFrC+l3AJE+4vDIgL+/YwMB5KFqpai0hCGYGHnAKMobTrZ/k93pUOeELmfUK2GVzaBsbPmS3a/6Y6BCN+5/9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703264765; c=relaxed/simple; bh=HUQMS9BYbuilQdKEkMSTbfOKR9ulIG4U7lySYGcmd6E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jk+3/ZBH6jVNFivqTTZbtR8xzbvXUwRy1zmBFT6i//RdDggV2PN32q5x2PtGRXU35EOvumgn/w3H89xdsJpGm6iUUHPpav8eqPeYEVk11SHP3oquKTYCw3U7opbbsGAF1riOYYuRcu31dDt0I6SYEE1GehO7L8LkX1ljfo40dQA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703264763; bh=HUQMS9BYbuilQdKEkMSTbfOKR9ulIG4U7lySYGcmd6E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QCjqLbaMJ9g9AW+FvfuIXnue2KFtjzi4m8nTyhU7mYC4/COMRjnqFh5KAk2Ft5371 1FHZtPWEzyjne2O3mWMsopc07TdwWmIA801ah7V3EC3WFV0Zr61DZkEP1YBuwhIiIe 8VtBWOvf/sX47DjiWdMr7PQc0XUCAYD8OMNIe/K4= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6BE901E0AC; Fri, 22 Dec 2023 12:06:03 -0500 (EST) Message-ID: <8d9712c7-a722-4b57-b9e5-10beb57f4653@simark.ca> Date: Fri, 22 Dec 2023 12:06:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/9] gdb: remove VALUE_NEXT_FRAME_ID, add value::next_frame_id Content-Language: en-US To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20231221191716.257256-1-simon.marchi@efficios.com> <20231221191716.257256-8-simon.marchi@efficios.com> <87frzu18qr.fsf@tromey.com> <443a741e-661e-42ea-96a5-62911ccc6a63@simark.ca> <87ttoayxuo.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87ttoayxuo.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-12-22 12:02, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I'm not sure I understand, which function do you think should return a > Simon> frame_info_ptr? > > value::next_frame_id (though also with a new name). > > value::fetch_lazy_register can just access the frame_id directly if it > really needs to. > > I don't feel super strongly about this. Ah ok I see. Well, even value::fetch_lazy_register does call frame_find_by_id, so I guess it would make sense, it wouldn't be a pessimization. Simon