From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105107 invoked by alias); 5 Sep 2017 03:00:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104893 invoked by uid 89); 5 Sep 2017 03:00:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Sep 2017 03:00:54 +0000 Received: from John-Baldwins-MacBook-Pro-2.local (unknown [216.9.110.13]) by mail.baldwin.cx (Postfix) with ESMTPSA id A54F810AF2A; Mon, 4 Sep 2017 23:00:52 -0400 (EDT) Subject: Re: [PATCH v2] Define an error function in the PPC simulator library. To: Pedro Alves , Luis Machado References: <20170405163332.82109-1-jhb@FreeBSD.org> <2136315.0HrDL9yZYa@ralph.baldwin.cx> <6ff2bd23-446a-b27c-0b04-2c0d6b92315b@redhat.com> Cc: gdb-patches@sourceware.org From: John Baldwin Message-ID: <8dcb1a42-4367-527e-1e5b-6f250c5e0e4c@FreeBSD.org> Date: Tue, 05 Sep 2017 03:00:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <6ff2bd23-446a-b27c-0b04-2c0d6b92315b@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00075.txt.bz2 On 9/4/17 7:19 AM, Pedro Alves wrote: > On 04/13/2017 06:18 PM, John Baldwin wrote: >> On Thursday, April 13, 2017 08:25:27 AM Luis Machado wrote: >>> On 04/05/2017 11:33 AM, John Baldwin wrote: >>>> Previously this used the error function from GDB directly when linked >>>> against GDB instead of the error method in the host callbacks >>>> structure. This was exposed via a link error when GDB was converted >>>> to C++. The error function invokes the error callback similar to >>>> sim_io_error. >>>> >>> >>> There is another implementation of error (...) in sim/ppc/main.c and >>> sim/ppc/misc.c. Should those be kept as is or should we only use the new >>> function you're providing? >> >> My understanding is that they should be kept as-is. This file is only used >> when linking the library against GDB (and actually, rereading the log message, >> I should reword the opening sentence to make this clearer). sim-calls.o isn't >> included in the actual library. Each consumer of the library is required >> to export a couple of symbols that libsim.a uses including "error". The dgen, >> igen, tmp-filter, tmp-ld-decode, tmp-ld-cache, and tmp-ld-insn programs use >> the functions from misc.c. psim uses the functions from main.c, and >> GDB uses the functions from sim-calls.o. > > It'd be nice to include this info somewhere, likely in the commit log. Will do. Is there still time to merge this into 8.0.1 (and if so, can you approve it)? Thanks! -- John Baldwin