From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3B6F13858D28 for ; Mon, 28 Aug 2023 18:15:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B6F13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 37SIFAM3027142 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Aug 2023 14:15:15 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 37SIFAM3027142 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1693246515; bh=V5Kvq1imsd6gmqZGU5cCaLCcEFqMa8VH0uMZmKkSXMc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=D+dLnc1RSPI+z0Lvi0FvTOp/QWOXLXcdT62OU73Gf3M3bKOBgXlVCjkab5tgKPCzF ydULRyBFzoLmsLw7Nsvs5cnEXOpG/Eg88J6DW95rNp4tqer1XnrwptxJ8jFCfRbSmd KhgnTtlxJRwvfHnPcGJlYOBp/XsY02e9YgeCC5do= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7A1181E092; Mon, 28 Aug 2023 14:15:10 -0400 (EDT) Message-ID: <8e44e9be-cc90-4b1e-ac01-79bd82f85416@polymtl.ca> Date: Mon, 28 Aug 2023 14:15:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 13/15] gdbserver: Use x86_xstate_layout to parse the XSAVE extended state area. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-14-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20230714155151.21723-14-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 28 Aug 2023 18:15:10 +0000 X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/14/23 11:51, John Baldwin wrote: > From: Aleksandar Paunovic > > Replace the extended state area fields of i387_xsave with methods which > return an offset into the XSAVE buffer. > > The two changed functions are called within all tests which runs > gdbserver. > > Signed-off-by: Aleksandar Paunovic > Co-authored-by: John Baldwin > --- > gdbserver/i387-fp.cc | 117 +++++++++++++++++++++++++------------------ > 1 file changed, 69 insertions(+), 48 deletions(-) > > diff --git a/gdbserver/i387-fp.cc b/gdbserver/i387-fp.cc > index a122e2d860b..f53a6cfc477 100644 > --- a/gdbserver/i387-fp.cc > +++ b/gdbserver/i387-fp.cc > @@ -82,6 +82,8 @@ struct i387_fxsave { > }; > > struct i387_xsave : public i387_fxsave { > + /* Size of i387_fxsave is 416 bytes. */ Add a gdb_static_assert to make sure of that? > + /* Memory address of 16 512-bit zmm16-31 values. */ > + unsigned char *zmm_space () > + { return xsave () + xsave_layout.zmm_offset; } Since this doesn't Would it be clearer to call this field (and method) zmm16_offset (zmm16_space), to make it clear that it's the space for the zmm registers starting at 16? In any case: Approved-By: Simon Marchi Simon