From: Simon Marchi <simark@simark.ca>
To: Mihails Strasuns <mihails.strasuns@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v3 3/9] [gdb/testsuite] share jit-protocol.h by all jit tests
Date: Fri, 17 Apr 2020 22:38:14 -0400 [thread overview]
Message-ID: <8e4b1d13-67ce-5b61-3634-f5f6d68acdd7@simark.ca> (raw)
In-Reply-To: <20200331171356.26126-3-mihails.strasuns@intel.com>
On 2020-03-31 1:13 p.m., Mihails Strasuns via Gdb-patches wrote:
> There was an existing jit-protocol.h defining common symbols needed for
> JIT-supporting application, however, it was only used by few tests.
> Others redeclared the same symbols.
>
> This unifies all tests to use jit-protocol.h
>
> gdb/testsuite/ChangeLog:
>
> 2020-02-18 Mihails Strasuns <mihails.strasuns@intel.com>
>
> * gdb.base/jit-attach-pie.c: use jit-protocol.h
> * gdb.base/jit-elf-main.c: use jit-protocol.h
> * gdb.base/jit-reader-host.c: use jit-protocol.h
> * gdb.base/jit-reader-simple-jit.c: use jit-protocol.h
> * gdb.base/jit-protocol.h: update definitions to match all usage
> contexts
Same comment about capital letter and period, that applies to all patches,
I'll stop mentioning it.
Ok with that fixed.
Simon
next prev parent reply other threads:[~2020-04-18 2:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166773>
2020-03-31 17:13 ` [PATCH v3 1/9] [gdb/testsuite] allow more registers in reader test Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 2/9] [gdb/testsuite] structured rename of jit test files Mihails Strasuns
2020-04-18 2:35 ` Simon Marchi
2020-03-31 17:13 ` [PATCH v3 3/9] [gdb/testsuite] share jit-protocol.h by all jit tests Mihails Strasuns
2020-04-18 2:38 ` Simon Marchi [this message]
2020-03-31 17:13 ` [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests Mihails Strasuns
2020-04-18 2:58 ` Simon Marchi
2020-04-20 7:35 ` Strasuns, Mihails
2020-04-20 13:08 ` Simon Marchi
2020-04-20 13:53 ` Simon Marchi
2020-03-31 17:13 ` [PATCH v3 5/9] [gdb/testsuite] add lib/jit-elf-helpers.exp Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 6/9] [gdb/testsuite] use -Ttext-segment for jit-elf tests Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 7/9] [gdb/testsuite] define jit function name via macro Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 8/9] [gdb/testsuite] add jit-elf-util.h and run jit function Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 9/9] [gdb/testsuite] handle compilation failures in jit-elf-helpers Mihails Strasuns
2020-04-14 10:08 ` [PATCH v3 1/9] [gdb/testsuite] allow more registers in reader test Strasuns, Mihails
2020-04-18 2:30 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4b1d13-67ce-5b61-3634-f5f6d68acdd7@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=mihails.strasuns@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).