From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83717 invoked by alias); 30 Aug 2019 19:03:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83705 invoked by uid 89); 30 Aug 2019 19:03:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2019 19:03:38 +0000 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 53D8E7FDF4 for ; Fri, 30 Aug 2019 19:03:37 +0000 (UTC) Received: by mail-wr1-f71.google.com with SMTP id v15so4688880wrg.13 for ; Fri, 30 Aug 2019 12:03:37 -0700 (PDT) Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id i18sm10447096wrp.91.2019.08.30.12.03.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2019 12:03:35 -0700 (PDT) Subject: Re: [PATCH v2] Improve ptrace-error detection on Linux targets To: Sergio Durigan Junior References: <20190819032918.3536-1-sergiodj@redhat.com> <20190826183205.19008-1-sergiodj@redhat.com> <28c4f743-91f1-59c3-83ff-3f791811f996@redhat.com> <87mufrai1z.fsf@redhat.com> <87ftljah3a.fsf@redhat.com> Cc: GDB Patches , Eli Zaretskii , Ruslan Kabatsayev From: Pedro Alves Message-ID: <8e681f53-bb82-87c5-dfb6-7c839b624cc2@redhat.com> Date: Fri, 30 Aug 2019 19:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87ftljah3a.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00658.txt.bz2 On 8/29/19 8:48 PM, Sergio Durigan Junior wrote: > You can see that we're calling "warning", which puts a newline at the > end of the string. I think it'd be best to just get rid of the > "\nError: " suffix. We'd then have something like: > > Starting program: /usr/bin/true > warning: Could not trace the inferior process. > warning: ptrace: Permission denied > .... > > WDYT? Sounds fine to me. Thanks, Pedro Alves