From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [gdb/testsuite] Add gdb-caching-proc.exp testcase
Date: Sat, 01 Dec 2018 08:04:00 -0000 [thread overview]
Message-ID: <8e9cd071-89de-ea62-6434-eebbcbd9ac28@suse.de> (raw)
In-Reply-To: <87tvjymjli.fsf@tromey.com>
On 30-11-18 20:49, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> 2018-10-09 Tom de Vries <tdevries@suse.de>
> Tom> * gdb.base/gdb-caching-proc.exp: New file.
>
> Thanks for the patch. I didn't see a review or see this go in, so
> hopefully this isn't redundant.
>
Hi Tom,
indeed this was not reviewed yet.
> Tom> +# Test gdb_caching_proc NAME
> Tom> +proc test_proc { name } {
> Tom> + set real_name gdb_real__$name
> Tom> +
> Tom> + set first [$real_name]
> Tom> + lappend resultlist $first
>
> I think this lappend is unnecessary...
>
> Tom> + set resultlist [list]
>
> ... because resultlist is reset here.
> But maybe you intended to hoist this earlier?
Yep, I did, fixed in the commit.
> Either way is fine by me.
>
> This is ok with this nit addressed.
Thanks for the review.
- Tom
prev parent reply other threads:[~2018-12-01 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 17:40 [PATCH][gdb/testsuite] Fix target_supports_scheduler_locking raciness Tom de Vries
2018-10-09 12:58 ` Pedro Alves
2018-10-09 13:47 ` [gdb/testsuite] Add gdb-caching-proc.exp testcase Tom de Vries
2018-11-05 9:05 ` [PING][gdb/testsuite] " Tom de Vries
2018-11-30 19:49 ` [gdb/testsuite] " Tom Tromey
2018-12-01 8:04 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e9cd071-89de-ea62-6434-eebbcbd9ac28@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).