From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AAA3F385BF86 for ; Thu, 2 Dec 2021 16:56:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AAA3F385BF86 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1B2Gu6lK016373 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 Dec 2021 11:56:10 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1B2Gu6lK016373 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EB1831EDEE; Thu, 2 Dec 2021 11:56:05 -0500 (EST) Message-ID: <8eabee75-e583-d636-2953-358a8b72b63e@polymtl.ca> Date: Thu, 2 Dec 2021 11:56:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] gdb/testsuite: update tests looking for "DWARF 2" debug format Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <0996654e-d859-675d-3247-c3ff942ba8a6@suse.de> <20211202160900.972963-1-simon.marchi@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 2 Dec 2021 16:56:06 +0000 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 16:56:13 -0000 On 2021-12-02 11:14, Tom de Vries wrote: > On 12/2/21 5:09 PM, Simon Marchi via Gdb-patches wrote: >> Commit ab557072b8ec ("gdb: use actual DWARF version in compunit's >> debugformat field") change the debug format string in "info source" to > > typo: change -> changes Fixed. >> show the actual DWARF version, rather than always show "DWARF 2". >> >> However, it failed to consider that some tests checked for the "DWARF 2" >> string to see if the test program is compiled with DWARF debug >> information. Since everything is compiled with DWARF 4 or 5 nowadays, >> that changed the behavior of those tests. Notably, it prevent the >> tests using skip_inline_var_tests to run. >> >> Grep through the testsuite for "DWARF 2" and change all occurrences I >> could find to use "DWARF [0-9]" instead (that string is passed to TCL's >> string match). >> > > LGTM. Pushed, thanks! Simon