From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 1BDC63858436 for ; Wed, 27 Sep 2023 07:52:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BDC63858436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F8CC1F8C0; Wed, 27 Sep 2023 07:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695801169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ScnlHAU89frfUpJZJf6hYqL+ISGZ/pMEZ4g7v2Fyiro=; b=VamucAoKGaw4OyLK9u11fdR8BtvzdEKurISQDiXiArluIy0FM6lQSiAxb2/+ph79CWFJon S5pbqrAYmiy/owCHR8ZccmezvCWrGve53IdPSo6a+TVikk726C21KcQDY6GgzxOc3jhnMh BcXLlf1snzhKvkSr9OFIK6Zn6RdSHvE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695801169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ScnlHAU89frfUpJZJf6hYqL+ISGZ/pMEZ4g7v2Fyiro=; b=GO/W9ZBGnqol7egvHejj7ogLT4hQAdXrlObsgSolKBqOBeFmF7Z0JIv3EILqA59Wg8wTTi 7ZauyvmILNXlKfDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 301EC1338F; Wed, 27 Sep 2023 07:52:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id phyFClHfE2U5VQAAMHmgww (envelope-from ); Wed, 27 Sep 2023 07:52:49 +0000 Message-ID: <8ed8360e-a553-49e9-93b1-a1ebcdaa52f6@suse.de> Date: Wed, 27 Sep 2023 09:52:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: Fix an ODR warning with byacc with GDB_YY_REMAP Content-Language: en-US To: Sam James Cc: Tom Tromey , Tom de Vries via Gdb-patches , Tom de Vries References: <20230912010238.3086346-1-sam@gentoo.org> <87bkdp59la.fsf@tromey.com> <87cyy4cbks.fsf@gentoo.org> From: Tom de Vries In-Reply-To: <87cyy4cbks.fsf@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/27/23 09:35, Sam James wrote: > > Tom de Vries writes: > >> On 9/26/23 15:48, Tom Tromey wrote: >>>>>>>> "Tom" == Tom de Vries via Gdb-patches writes: >>> Tom> On 9/12/23 02:58, Sam James wrote: >>>>> - Tom commented that it probably constitutes obvious but while I >>>>> have binutils access, I'm not listed in gdb/MAINTAINERS for >>>>> write-after-approval, so I'm hesitant. >>> Tom> GDB write-after-approval requires a copyright assignment that >>> covers >>> Tom> gdb. Do you have a copyright assignment for gdb? >>> I think this patch could land without the paperwork, since it is >>> small. >> >> Agreed, which is why I've already approved it and asked Sam to commit it. >> >>> And, it would be good to get it in before GDB 14, since it is a build >>> fix. >> >> Agreed. Sam, is there anything preventing you from committing this? >> If so, then I can take care of it. > > Sorry folks, done now - Tom's question had prompted me to go finally > figure out the copyright assignment bits and I got distracted. > > Pushed! > Hi, thanks for pushing it. I saw you used a Copyright-paperwork-exempt tag, it's good to make that explicit (FWIW, I was not familiar with the tag itself, but I see there's prior usage). Just want to mention: my understanding is that this commit goes into the bucket legally insignificant contributions. If you keep adding similar commits, at some point this bucket will overflow and you need a copyright assignment to keep contributing regardless of the nature of the patch. I wish these things were less complicated ... Thanks, - Tom