Re: [PATCH] [gdb/testsuite] Remove Term::command_no_prompt_prefix

[Tom de Vries <tdevries@suse.de>]

On 6/9/23 09:26, Tom de Vries via Gdb-patches wrote:
> Say we run test-case gdb.tui/basic.exp.  It calls Term::enter_tui, which does:
> ...
> 	command_no_prompt_prefix "tui enable"
> ...
> 
> The proc command_no_prompt_prefix is documented as:
> ...
>      # As proc command, but don't wait for an initial prompt.  This is used for
>      # initial terminal commands, where there's no prompt yet.
> ...
> 
> Indeed, before the "tui enable" command, the tuiterm is empty, so there is no
> prompt.
> 
> The reason that there is no prompt, is that:
> - in order for tuiterm to show something, its input processing procs need to
>    be called, and
> - the initial gdb prompt, and subsequent prompts generated by gdb_test-style
>    procs, are all consumed by those procs instead.
> 
> This is in principle not a problem, but the absence of a prompt makes a
> tuiterm session look less like a session on an actual xterm.
> 
> Fix this by using a new proc gen_prompt, that:
> - generates a prompt using ^C (though also something like echo \n would work)
> - consumes the response before the prompt using gdb_expect
> - consumes the prompt using Term::wait_for "".
> 
> A fix was necessary to Term::wait_for, to make sure that Term::wait_for ""
> consumes just one prompt.
> 
> This allows us to use the regular proc command instead:
> ...
>          gen_prompt
> 	command "tui enable"
> ...
> such that we have in tuiterm:
> ...
> (gdb) tui enable
> ...
> instead of:
> ...
> tui enable
> ...
> 
> Fix all uses of command_no_prompt_prefix, and remove it.
> 

I split up the patch in two parts (one separate patch for the change in 
Term::wait_for), and rather than removing command_no_prompt_prefix, 
reimplemented it.  Committed, and posted here:
- https://sourceware.org/pipermail/gdb-patches/2023-June/200422.html
- https://sourceware.org/pipermail/gdb-patches/2023-June/200423.html

Thanks,
- Tom