From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72841 invoked by alias); 12 Jun 2018 14:43:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72826 invoked by uid 89); 12 Jun 2018 14:43:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=staff X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jun 2018 14:43:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54648401EF23; Tue, 12 Jun 2018 14:43:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44DE016875; Tue, 12 Jun 2018 14:43:18 +0000 (UTC) Subject: Re: [PATCH v2 02/10] Add Aarch64 SVE Linux headers To: Alan Hayward , Simon Marchi References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-3-alan.hayward@arm.com> <9FBBFBF2-9363-49AA-8BC3-20E4E0AFBFED@arm.com> <5862fa9c22cc48d86256686e74d60f20@polymtl.ca> <82743c0795488492486076685b9f8828@polymtl.ca> Cc: GDB Patches , Simon Marchi , nd From: Pedro Alves Message-ID: <8f6d2b87-707a-3e34-325c-ed9338e9c1f6@redhat.com> Date: Tue, 12 Jun 2018 14:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00308.txt.bz2 On 06/12/2018 03:37 PM, Alan Hayward wrote: > > >> On 8 Jun 2018, at 16:23, Simon Marchi wrote: >> >> On 2018-06-08 10:37, Simon Marchi wrote: >>> The code looks good to me, thanks. I am still unsure about the >>> licensing side of it, let me ask the FSF people about it, I'll come >>> back to you when it's done. I hope it won't take too long! >> >> Hi Alan, >> >> After discussion with other maintainers, it was suggested to avoid involving the legal staff if we want to resolve this anytime soon. >> >> Since ARM already holds the copyright to these header files anyway (they were all written by ARM people), you may be able to submit that code as regular FSF-assigned code, without changing the status of the kernel copy. But nobody here is a lawyer, so nobody wants to say for sure :). >> >> Maybe it's ok after all if we don't include these headers (at least for now), and require that GDB for native AArch64 is built against the headers of a >= 4.15 kernel? They can always be included later, but it would avoid delaying the inclusion of the feature, since you want to have it before we branch 8.2. >> > > Sorry, I did miss this one (I think I sent my reply to the previous > one more or less the same time you sent this). > > If I commit this, What's "this" ? How about we add a configure check to check if the system headers support the needed SVE bits, and guard the native gdb SVE bits with HAVE_AARCH64_SVE or something like that? (I think) this is going to cause buildbot to break > for the aarch64 builds. Thanks, Pedro Alves