From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id A9CE83851C12 for ; Wed, 27 May 2020 16:52:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A9CE83851C12 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 82593AC61; Wed, 27 May 2020 16:52:50 +0000 (UTC) Subject: Re: [PATCH v2 28/42] Remove dwarf2_per_cu_data::objfile () From: Tom de Vries To: Simon Marchi , gdb-patches@sourceware.org References: <20200512210913.5593-1-simon.marchi@efficios.com> <20200512211250.6230-29-simon.marchi@efficios.com> <04473d43-9719-436b-648a-bdc8e5f55751@suse.de> Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <8fb3a75b-ed6e-d3f8-af7b-20ca0229844e@suse.de> Date: Wed, 27 May 2020 18:52:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <04473d43-9719-436b-648a-bdc8e5f55751@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2020 16:52:50 -0000 On 27-05-2020 18:27, Tom de Vries wrote: > On 12-05-2020 23:12, Simon Marchi via Gdb-patches wrote: >> @@ -724,10 +721,13 @@ class dwarf_evaluate_loc_desc : public dwarf_expr_context >> caller_frame = get_prev_frame (frame); >> >> parameter = dwarf_expr_reg_to_entry_parameter (frame, kind, kind_u, >> - &caller_per_cu); >> + &caller_per_cu, >> + &caller_per_objfile); >> data_src = deref_size == -1 ? parameter->value : parameter->data_value; >> size = deref_size == -1 ? parameter->value_size : parameter->data_value_size; >> >> + gdb_assert (this->per_objfile == caller_per_objfile); >> + > > Hi, > > I'm running into this assert here: > ... > (gdb) PASS: gdb.base/catch-load.exp: plain load: catch load > continue^M > Continuing.^M > ^M > Catchpoint 3^M > Inferior loaded > /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/catch-load/catch-load-so.so^M > dl_open_worker (/data/gdb_versions/devel/src/gdb/dwarf2/loc.c:729: > internal-error: virtual void > dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value(call_site_parameter_kind, > call_site_parameter_u, int): Assertion `this->per_objfile == > caller_per_objfile' failed.^M > A problem internal to GDB has been detected,^M > further debugging may prove unreliable.^M > Quit this debugging session? (y or n) FAIL: gdb.base/catch-load.exp: > plain load: continue (GDB internal error) > ... > > Minimal reproducer: > ... > $ gdb -batch outputs/gdb.base/catch-load/catch-load \ > -ex start \ > -ex "catch load" \ > -ex continue > ... > By disabling the assert, the test passes, and with the minimal reproducer, we have: ... $ gdb -batch outputs/gdb.base/catch-load/catch-load \ -ex start \ -ex "catch load" -ex continue Temporary breakpoint 1 at 0x40058f: file /data/gdb_versions/devel/src/gdb/testsuite/gdb.base/catch-load.c, line 36. Temporary breakpoint 1, main () at /data/gdb_versions/devel/src/gdb/testsuite/gdb.base/catch-load.c:36 36 h = dlopen (libname, RTLD_LAZY); Catchpoint 2 (load) Catchpoint 2 Inferior loaded /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/catch-load/catch-load-so.so dl_open_worker (a=a@entry=0x7fffffffd880) at dl-open.c:509 509 LIBC_PROBE (reloc_complete, 3, args->nsid, r, new); ... Thanks, - Tom