From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id EE58A3858D1E for ; Tue, 3 Jan 2023 18:59:55 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 303IxnZ2006763 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Jan 2023 13:59:54 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 303IxnZ2006763 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1672772394; bh=T3IEbU3AUvpqCvpEWHjy9Q8IoQ/sRtmiGXgRoapYBnw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=VxDVFRGmVWxXAXlulf3dk29qNbAVqAdl6gsTuRuzvpJCl6JAqGG1JDuzWbThdNkDW WBLSKBjpnCLiVPbJeaKQRqJ3Un7ehBWca2LER7WkxqmQDtR7mr7qN0TAcI5djkkV3H YPieRHIk8GnKZAppZm4bJXZbs/mAMGg9lD+X9kcw= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4708C1E112; Tue, 3 Jan 2023 13:59:49 -0500 (EST) Message-ID: <8fb7eaff-87be-8dde-799f-dd6bf3187969@polymtl.ca> Date: Tue, 3 Jan 2023 13:59:48 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 06/13] gdb: move frame_info_ptr to frame.{c,h} To: Bruno Larsen , gdb-patches@sourceware.org References: <20221214033441.499512-1-simon.marchi@polymtl.ca> <20221214033441.499512-7-simon.marchi@polymtl.ca> <92c0b9cf-41e4-08df-0212-e3b5e707bfe4@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <92c0b9cf-41e4-08df-0212-e3b5e707bfe4@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 3 Jan 2023 18:59:49 +0000 X-Spam-Status: No, score=-3033.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/22 12:01, Bruno Larsen wrote: > On 14/12/2022 04:34, Simon Marchi via Gdb-patches wrote: >> Change-Id: Ic5949759e6262ea0da6123858702d48fe5673fea >> --- >> gdb/Makefile.in | 1 - >> gdb/c-lang.h | 1 + >> gdb/dwarf2/call-site.h | 2 +- >> gdb/frame-info.c | 65 ------------- >> gdb/frame-info.h | 211 ----------------------------------------- >> gdb/frame.c | 43 ++++++++- >> gdb/frame.h | 188 +++++++++++++++++++++++++++++++++++- >> gdb/gdbtypes.h | 2 - >> gdb/symtab.h | 1 + >> 9 files changed, 230 insertions(+), 284 deletions(-) >> delete mode 100644 gdb/frame-info.c >> delete mode 100644 gdb/frame-info.h > > Not sure if this is on purpose but this commit doesn't seem to have a > commit message. If you'd like some extra context to write it, I ran > into cyclic includes when writing the original version (which you > found and fixed). Since I am not familiar with the rest of the code, a > new file seemed like a good enough hack to get things working. Now > that you solved the cyclic includes, it makes sense to remove the > files. No, it wasn't intended, I must have forgotten to write the message for this commit! Here it is, I will update my local branch: A patch later in this series will make frame_info_ptr access some fields internal to frame_info, which we don't want to expose outside of frame.c. Move the frame_info_ptr class to frame.h, and the definitions to frame.c. Remove frame-info.c and frame-info.h. Simon