* Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources
[not found] ` <5473A3D3.901@redhat.com>
@ 2015-01-03 22:55 ` Andrew Pinski
2015-01-04 9:35 ` Bin.Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Pinski @ 2015-01-03 22:55 UTC (permalink / raw)
To: Jeff Law, binutils, gdb-patches; +Cc: GCC Patches, Ian Lance Taylor
On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law <law@redhat.com> wrote:
> On 11/22/14 21:20, Andrew Pinski wrote:
>>
>> Hi,
>> The problem here is here is that OBJCOPY is not being set to the
>> newly built objcopy when compiling libgo. This patch adds
>> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when
>> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET.
>>
>> I noticed this issue when building an aarch64 cross compile on an
>> older system where objcopy did not understand aarch64.
>>
>> OK? Bootstrapped and tested on x86_64 with no regressions. Also
>> tested with a combined build for a cross compiler to
>> aarch64-linux-gnu.
>>
>> Thanks,
>> Andrew Pinski
>>
>>
>> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also.
>> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET.
>> (BASE_TARGET_EXPORTS): Add OBJCOPY.
>> (OBJCOPY_FOR_TARGET): New variable.
>> (EXTRA_TARGET_FLAGS): Add OBJCOPY.
>> * Makefile.in: Regenerate.
>> * configure.ac: Check for already installed target objcopy.
>> Also GCC_TARGET_TOOL on objcopy.
>> * configure: Regenerate.
>
> OK
Committed to GCC and gdb/binutils repos now.
Thanks,
Andrew
> Jeff
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources
2015-01-03 22:55 ` [PATCH/TopLevel] Fix compiling libgo with a combined sources Andrew Pinski
@ 2015-01-04 9:35 ` Bin.Cheng
2015-01-04 10:31 ` pinskia
0 siblings, 1 reply; 3+ messages in thread
From: Bin.Cheng @ 2015-01-04 9:35 UTC (permalink / raw)
To: Andrew Pinski
Cc: Jeff Law, binutils, gdb-patches, GCC Patches, Ian Lance Taylor
On Sun, Jan 4, 2015 at 6:55 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law <law@redhat.com> wrote:
>> On 11/22/14 21:20, Andrew Pinski wrote:
>>>
>>> Hi,
>>> The problem here is here is that OBJCOPY is not being set to the
>>> newly built objcopy when compiling libgo. This patch adds
>>> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when
>>> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET.
>>>
>>> I noticed this issue when building an aarch64 cross compile on an
>>> older system where objcopy did not understand aarch64.
>>>
>>> OK? Bootstrapped and tested on x86_64 with no regressions. Also
>>> tested with a combined build for a cross compiler to
>>> aarch64-linux-gnu.
>>>
>>> Thanks,
>>> Andrew Pinski
>>>
>>>
>>> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also.
>>> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET.
>>> (BASE_TARGET_EXPORTS): Add OBJCOPY.
>>> (OBJCOPY_FOR_TARGET): New variable.
>>> (EXTRA_TARGET_FLAGS): Add OBJCOPY.
>>> * Makefile.in: Regenerate.
>>> * configure.ac: Check for already installed target objcopy.
>>> Also GCC_TARGET_TOOL on objcopy.
>>> * configure: Regenerate.
>>
>> OK
>
>
> Committed to GCC and gdb/binutils repos now.
>
> Thanks,
> Andrew
Hi Andrew,
> + elif test "x$target" = "x$host"; then
> + # We can use an host tool
> + OBJCOPY_FOR_TARGET='$(OBJDUMP)'
Is it a typo for '$(OBJCOPY)' ?
Thanks,
bin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources
2015-01-04 9:35 ` Bin.Cheng
@ 2015-01-04 10:31 ` pinskia
0 siblings, 0 replies; 3+ messages in thread
From: pinskia @ 2015-01-04 10:31 UTC (permalink / raw)
To: Bin.Cheng; +Cc: Jeff Law, binutils, gdb-patches, GCC Patches, Ian Lance Taylor
> On Jan 4, 2015, at 1:35 AM, Bin.Cheng <amker.cheng@gmail.com> wrote:
>
>> On Sun, Jan 4, 2015 at 6:55 AM, Andrew Pinski <pinskia@gmail.com> wrote:
>>> On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law <law@redhat.com> wrote:
>>>> On 11/22/14 21:20, Andrew Pinski wrote:
>>>>
>>>> Hi,
>>>> The problem here is here is that OBJCOPY is not being set to the
>>>> newly built objcopy when compiling libgo. This patch adds
>>>> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when
>>>> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET.
>>>>
>>>> I noticed this issue when building an aarch64 cross compile on an
>>>> older system where objcopy did not understand aarch64.
>>>>
>>>> OK? Bootstrapped and tested on x86_64 with no regressions. Also
>>>> tested with a combined build for a cross compiler to
>>>> aarch64-linux-gnu.
>>>>
>>>> Thanks,
>>>> Andrew Pinski
>>>>
>>>>
>>>> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also.
>>>> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET.
>>>> (BASE_TARGET_EXPORTS): Add OBJCOPY.
>>>> (OBJCOPY_FOR_TARGET): New variable.
>>>> (EXTRA_TARGET_FLAGS): Add OBJCOPY.
>>>> * Makefile.in: Regenerate.
>>>> * configure.ac: Check for already installed target objcopy.
>>>> Also GCC_TARGET_TOOL on objcopy.
>>>> * configure: Regenerate.
>>>
>>> OK
>>
>>
>> Committed to GCC and gdb/binutils repos now.
>>
>> Thanks,
>> Andrew
>
> Hi Andrew,
>
>> + elif test "x$target" = "x$host"; then
>> + # We can use an host tool
>> + OBJCOPY_FOR_TARGET='$(OBJDUMP)'
> Is it a typo for '$(OBJCOPY)' ?
Yes it is a pasto. I think the fix for this would be obvious.
Thanks,
Andrew
>
> Thanks,
> bin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-04 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CA+=Sn1nMV44+3jMMZ0WJQbX=KTaETk7ZC5ZzOv3K-wYdQiCPkw@mail.gmail.com>
[not found] ` <5473A3D3.901@redhat.com>
2015-01-03 22:55 ` [PATCH/TopLevel] Fix compiling libgo with a combined sources Andrew Pinski
2015-01-04 9:35 ` Bin.Cheng
2015-01-04 10:31 ` pinskia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).