From: Sandra Loosemore <sandra@codesourcery.com>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
<qiyao@sourceware.org>
Subject: Re: [patch] add missing gcc_target_options method for nios2
Date: Tue, 18 Sep 2018 19:36:00 -0000 [thread overview]
Message-ID: <9067a8bb-9b72-c9ce-f4a2-2ba276be7c79@codesourcery.com> (raw)
In-Reply-To: <87worisjkv.fsf@tromey.com>
On 09/18/2018 01:15 PM, Tom Tromey wrote:
>>>>>> "Sandra" == Sandra Loosemore <sandra@codesourcery.com> writes:
>
> Sandra> While looking at gdb.compile test failures on nios2, I found that it
> Sandra> was passing an invalid option to gcc, due to another missing target
> Sandra> method. This patch doesn't make the "compile" command work for me yet
> Sandra> (see PRs 23671 and 23672 that I filed last night) but it seems like
> Sandra> something that will be necessary to get there. OK to commit?
>
> Sandra> -Sandra
>
> Sandra> commit fce4579114f47246773caa9c68969a90794ff90d
> Sandra> Author: Sandra Loosemore <sandra@codesourcery.com>
> Sandra> Date: Sun Sep 16 14:35:43 2018 -0700
>
> Sandra> Add gcc_target_options hook for nios2.
>
> Sandra> 2018-09-16 Sandra Loosemore <sandra@codesourcery.com>
>
> Sandra> gdb/
> Sandra> * nios2-tdep.c (nios2_gcc_target_options): New.
> Sandra> (nios2_gdb_arch_init): Install new hook.
>
> Thank you. This is ok.
>
> The default gcc_target_options seems overly specific to me.
Me too. Based on reading the code, I've gotten the impression that the
compile functionality in GDB has not been well-tested on any target
other than native x86 GNU/Linux and some of the design/implementation
decisions reflect that.
-Sandra
prev parent reply other threads:[~2018-09-18 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 15:22 Sandra Loosemore
2018-09-18 19:16 ` Tom Tromey
2018-09-18 19:36 ` Sandra Loosemore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9067a8bb-9b72-c9ce-f4a2-2ba276be7c79@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyao@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).