From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83411 invoked by alias); 18 Sep 2018 19:36:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83392 invoked by uid 89); 18 Sep 2018 19:36:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=night, PRs, H*r:0700 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 19:36:57 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1g2Lnr-0006hC-Np from Sandra_Loosemore@mentor.com ; Tue, 18 Sep 2018 12:36:55 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 18 Sep 2018 12:36:53 -0700 Subject: Re: [patch] add missing gcc_target_options method for nios2 To: Tom Tromey CC: "gdb-patches@sourceware.org" , References: <87worisjkv.fsf@tromey.com> From: Sandra Loosemore Message-ID: <9067a8bb-9b72-c9ce-f4a2-2ba276be7c79@codesourcery.com> Date: Tue, 18 Sep 2018 19:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87worisjkv.fsf@tromey.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00653.txt.bz2 On 09/18/2018 01:15 PM, Tom Tromey wrote: >>>>>> "Sandra" == Sandra Loosemore writes: > > Sandra> While looking at gdb.compile test failures on nios2, I found that it > Sandra> was passing an invalid option to gcc, due to another missing target > Sandra> method. This patch doesn't make the "compile" command work for me yet > Sandra> (see PRs 23671 and 23672 that I filed last night) but it seems like > Sandra> something that will be necessary to get there. OK to commit? > > Sandra> -Sandra > > Sandra> commit fce4579114f47246773caa9c68969a90794ff90d > Sandra> Author: Sandra Loosemore > Sandra> Date: Sun Sep 16 14:35:43 2018 -0700 > > Sandra> Add gcc_target_options hook for nios2. > > Sandra> 2018-09-16 Sandra Loosemore > > Sandra> gdb/ > Sandra> * nios2-tdep.c (nios2_gcc_target_options): New. > Sandra> (nios2_gdb_arch_init): Install new hook. > > Thank you. This is ok. > > The default gcc_target_options seems overly specific to me. Me too. Based on reading the code, I've gotten the impression that the compile functionality in GDB has not been well-tested on any target other than native x86 GNU/Linux and some of the design/implementation decisions reflect that. -Sandra