From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 909553858D38 for ; Wed, 1 Feb 2023 03:09:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 909553858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AB08E1E0D3; Tue, 31 Jan 2023 22:09:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675220994; bh=gdgr7pM1sT+xe/AipFQSPnHExOnEDKmYNAtlUpztos8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YIxflC8puTsQlZMCXG98n+IrZ29NCAJ+mXYZ0OFAWCEihwE+ULfhW1phtVOwe5irb Ep0zfVWGhBj+at6iPgoAXuuyJ53rtR83lcGWLYt6GT8E5ojqnEvebqJ6Gvpmf5eu90 3slPcJM4pVFg8f9iVNEVnfIo+b7bnkvl4WK6m3yw= Message-ID: <90cdc238-e450-dd4d-9f61-45e3d5ef0f5b@simark.ca> Date: Tue, 31 Jan 2023 22:09:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] gdb/dwarf: rename cooked_index_vector to cooked_index Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20230131182721.71119-1-simon.marchi@efficios.com> <20230131182721.71119-2-simon.marchi@efficios.com> <87y1pijudy.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87y1pijudy.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/31/23 15:56, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> See previous patch's commit message for rationale. > > I've found that "previous" is more confusing when reading the git log. > Maybe just a reference to the _shard rename would be sufficient here > though. > > Approved-By: Tom Tromey Argh, I'm tired, and I pushed the patches before addressing your comment, sorry about that. Simon