From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id A7E803857411
 for <gdb-patches@sourceware.org>; Wed,  1 Sep 2021 13:00:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7E803857411
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 181Cxse2019700
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Wed, 1 Sep 2021 08:59:59 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 181Cxse2019700
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 14EE91ECEB;
 Wed,  1 Sep 2021 08:59:54 -0400 (EDT)
Subject: Re: [PATCH 1/2] gdbtypes.c: Add the case for
 FIELD_LOC_KIND_DWARF_BLOCK
To: =?UTF-8?Q?Alexandra_H=c3=a1jkov=c3=a1?= <alexandra.khirnova@gmail.com>,
 gdb-patches@sourceware.org
References: <20210831203447.763323-1-ahajkova@redhat.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <90da4978-891f-dfb3-f94b-2d560385126a@polymtl.ca>
Date: Wed, 1 Sep 2021 08:59:53 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210831203447.763323-1-ahajkova@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 1 Sep 2021 12:59:54 +0000
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Sep 2021 13:00:11 -0000

On 2021-08-31 4:34 p.m., Alexandra Hájková via Gdb-patches wrote:
> From: Alexandra Hájková <ahajkova@redhat.com>
> 
> The case for FIELD_LOC_KIND_DWARF_BLOCK was missing for
> switch TYPE_FIELD_LOC_KIND. Thas caused an internal-error
> under some circumstances.
> 
> Fixes bug 28030.

Hi,

Please add the git trailer:

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28030

LGTM with that added.

Simon