From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 08115382BEB6 for ; Thu, 8 Dec 2022 13:33:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08115382BEB6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 42B02337B1; Thu, 8 Dec 2022 13:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1670506401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oHBpiPbNUerkF1vGpYBQKoMVbx1yhTb3Y5IAaE7DIlw=; b=J+fqhvOeG2aASoKR6smCm2dR+AolMQKXUTmK42FmsQMCDL7yUuv/0PRPFr0esNdCtvJHkF ebrskfKae4RaiVDfvcDc5DT+NZ5/shZscsUmGB4vZSf280fTFkClXmuYSEF+y8iQmYNI7q h817fUF43EfOp8QU2jJ9D2G6EeNFITA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1670506401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oHBpiPbNUerkF1vGpYBQKoMVbx1yhTb3Y5IAaE7DIlw=; b=N9AYHfNKomtc4JCR3gifa0nil2ovi6rVhVkG0K75xI/z5VQgIWIpNmknpm4X4K+td/xokV kJ6YUYekocbF2mCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 26328138E0; Thu, 8 Dec 2022 13:33:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WQ4tCKHnkWP5VAAAMHmgww (envelope-from ); Thu, 08 Dec 2022 13:33:21 +0000 Message-ID: <90e29d7d-eec8-98ac-6df3-7add583f6c75@suse.de> Date: Thu, 8 Dec 2022 14:33:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC] [gdb] Stop on undetermined longjmp target during next To: Andreas Schwab , Tom de Vries via Gdb-patches Cc: Simon Marchi References: <20221208113140.1231-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/22 13:02, Andreas Schwab wrote: > On Dez 08 2022, Tom de Vries via Gdb-patches wrote: > >> diff --git a/gdb/infrun.c b/gdb/infrun.c >> index c67458b30b6..51bc72dae5f 100644 >> --- a/gdb/infrun.c >> +++ b/gdb/infrun.c >> @@ -6650,7 +6650,8 @@ process_event_stop_test (struct execution_control_state *ecs) >> { >> infrun_debug_printf ("BPSTAT_WHAT_SET_LONGJMP_RESUME " >> "(!gdbarch_get_longjmp_target)"); >> - keep_going (ecs); >> + warning (_("GDB can't determine the longjmp target")); > > It's quite unusual to talk about yourself in the third person. > I suppose it is. It's not unusual though, I can find quite a few examples in the gdb sources. I think that stressing that the warning comes from gdb is not a bad idea, because warnings might also be generated by inferiors. Thanks, - Tom