From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E06A7385696D for ; Mon, 12 Sep 2022 12:18:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E06A7385696D Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-299-mFZdSt73PkuTCrwtSHq6qQ-1; Mon, 12 Sep 2022 08:18:11 -0400 X-MC-Unique: mFZdSt73PkuTCrwtSHq6qQ-1 Received: by mail-wr1-f72.google.com with SMTP id a13-20020adfbc4d000000b00228631ddfafso1571333wrh.9 for ; Mon, 12 Sep 2022 05:18:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=XD5EtVrIDQLDkvRxsVWMqZKNNj4dlug2COdFHLWwYI4=; b=6WvIfVovE9x/P0jiewVsuveVd4PEJrX1ChZ2j3iHRIRfzRMDGZBiIPueOvAY4UuSuc tr9loR+ujrY0qmZtoIosTw6EW3diF8woGmmoFfgfro2jRpIO0tt69W6S0YltSDhLybUx cmHGeMCo7FTjiAqIa3WoqphXK5jXw6ccXhFcVCzCDRZM0yzCmyukpiKS+fWcvKlg5J18 oN5P1XFaemBQLB2ywtaGXtk8913BXSNsYa4bsdKewD3JTG9/RtSiUxYM8KzOeqSh8GFn +LARtCqt3djLxhjqZctmVGlvxGHj4TChR5j52qHoO3m24DECaMOWe3NGYBBAwfw807OC O1JA== X-Gm-Message-State: ACgBeo3d5sHyMgcpNGjoQ6JSpZC+meany5DsRJIE2ohgw8hW3kOePhUS t8yzF+42sXJlxA1s1pGrbixJCP02RabIZ23vlq0V3KBvxi2jb4sCPQv6SkI8cCL4d7MJVmDQTyC NMm3eS9eUepReZJ+eU321Xg== X-Received: by 2002:a05:600c:3c9b:b0:3a6:58b2:b80 with SMTP id bg27-20020a05600c3c9b00b003a658b20b80mr13835091wmb.132.1662985089884; Mon, 12 Sep 2022 05:18:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR6SBQIC392PwwGeLImt0EHwcGscRX1Yg/n+4JKQmNSMhSHL/y9PxBtUcyttxI15bY/ARYVRQA== X-Received: by 2002:a05:600c:3c9b:b0:3a6:58b2:b80 with SMTP id bg27-20020a05600c3c9b00b003a658b20b80mr13835081wmb.132.1662985089661; Mon, 12 Sep 2022 05:18:09 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id l14-20020adfe9ce000000b0022a34a2e091sm7263982wrn.22.2022.09.12.05.18.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 05:18:09 -0700 (PDT) Message-ID: <90e4f522-d50d-2115-963e-d71572ad42c0@redhat.com> Date: Mon, 12 Sep 2022 14:18:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 06/15] fix gdb.base/access-mem-running.exp for clang testing To: Andrew Burgess , gdb-patches@sourceware.org References: <20220720194441.168906-1-blarsen@redhat.com> <20220720194441.168906-8-blarsen@redhat.com> <87pmg1kk06.fsf@redhat.com> From: Bruno Larsen In-Reply-To: <87pmg1kk06.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 12:18:14 -0000 thanks, pushed! Cheers, Bruno On 12/09/2022 11:41, Andrew Burgess wrote: > Bruno Larsen via Gdb-patches writes: > >> Clang was optimizing global_var away because it was not being used >> anywhere. this commit fixes that by adding the attribute used it. >> --- >> gdb/testsuite/gdb.base/access-mem-running.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.base/access-mem-running.c b/gdb/testsuite/gdb.base/access-mem-running.c >> index 6335f1bf199..cff6f0da820 100644 >> --- a/gdb/testsuite/gdb.base/access-mem-running.c >> +++ b/gdb/testsuite/gdb.base/access-mem-running.c >> @@ -19,7 +19,7 @@ >> >> static unsigned int global_counter = 1; >> >> -static volatile unsigned int global_var = 123; >> +static volatile unsigned int __attribute__((used)) global_var = 123; >> >> static void >> maybe_stop_here () > LGTM. Feel free to merge this. > > Thanks, > Andrew >