From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 292CE3858C2C
 for <gdb-patches@sourceware.org>; Thu, 30 Sep 2021 12:14:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 292CE3858C2C
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18UCCpei008921
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Thu, 30 Sep 2021 08:12:56 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18UCCpei008921
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 2E2AD1EDF7;
 Thu, 30 Sep 2021 08:12:51 -0400 (EDT)
Message-ID: <90e82ecb-d1ab-d866-ccdb-b6ab64e52f5e@polymtl.ca>
Date: Thu, 30 Sep 2021 08:12:49 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH v4 1/4] gdb: Introduce setting construct within
 cmd_list_element
Content-Language: en-US
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
References: <20210929215011.1489639-1-lsix@lancelotsix.com>
 <20210929215011.1489639-2-lsix@lancelotsix.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
In-Reply-To: <20210929215011.1489639-2-lsix@lancelotsix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 30 Sep 2021 12:12:51 +0000
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2021 12:14:01 -0000

> @@ -667,26 +701,35 @@ get_setshow_command_value_string (const cmd_list_element *c)
>        break;
>      case var_uinteger:
>      case var_zuinteger:
> -      if (c->var_type == var_uinteger
> -	  && *(unsigned int *) c->var == UINT_MAX)
> -	stb.puts ("unlimited");
> -      else
> -	stb.printf ("%u", *(unsigned int *) c->var);
> +      {
> +	unsigned int const value = var.get<unsigned int> ();

As Pedro mentioned, we prefer "const unsigned int" (here and below).

LGTM with that fixed.

Simon