From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id BC365385843E for ; Mon, 4 Apr 2022 16:58:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC365385843E Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 3A0D535FA18; Mon, 4 Apr 2022 12:58:56 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id sGhyJ51ACq7y; Mon, 4 Apr 2022 12:58:55 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id CB0FB35FB83; Mon, 4 Apr 2022 12:58:55 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com CB0FB35FB83 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id o-1ggBnn0WT7; Mon, 4 Apr 2022 12:58:55 -0400 (EDT) Received: from [172.16.0.144] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by mail.efficios.com (Postfix) with ESMTPSA id 67F0435F77F; Mon, 4 Apr 2022 12:58:55 -0400 (EDT) Message-ID: <9109004e-c815-64ea-90ae-f69daa341994@efficios.com> Date: Mon, 4 Apr 2022 12:58:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] gdb: rename start_symtab/end_symtab to start_compunit_symtab/end_compunit_symtab Content-Language: tl To: Tom Tromey , Simon Marchi via Gdb-patches References: <20220328221717.2896842-1-simon.marchi@efficios.com> <20220328221717.2896842-2-simon.marchi@efficios.com> <87lewkkdyg.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87lewkkdyg.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3034.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 16:58:58 -0000 On 2022-04-04 12:31, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> It's a bit confusing because we have both "compunit_symtab" and "symtab" > Simon> types, and many methods and functions containing "start_symtab" or > Simon> "end_symtab", which actually deal with compunit_symtabs. I believe this > Simon> comes from the time before compunit_symtab was introduced, where > Simon> symtab did the job of both. > > Simon> Rename everything I found containing start_symtab or end_symtab to use > Simon> start_compunit_symtab or end_compunit_symtab. > > Seems reasonable to me. > > Tom Thanks, pushed both patches. Simon