From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125859 invoked by alias); 7 Dec 2017 18:50:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125845 invoked by uid 89); 7 Dec 2017 18:50:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Dec 2017 18:50:24 +0000 Received: from ESESSHC017.ericsson.se (Unknown_Domain [153.88.183.69]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id B0.02.13994.D6D892A5; Thu, 7 Dec 2017 19:50:21 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.69) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 7 Dec 2017 19:50:20 +0100 Received: from [132.207.200.163] (132.207.200.163) by AMSPR07MB311.eurprd07.prod.outlook.com (2a01:111:e400:802f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.3; Thu, 7 Dec 2017 18:50:19 +0000 Subject: Re: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector To: "Metzger, Markus T" , Simon Marchi , "gdb-patches@sourceware.org" References: <20171202164937.13641-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <9142baa8-d50b-1b14-3809-20adbb0b5488@ericsson.com> Date: Thu, 07 Dec 2017 18:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR05CA0036.namprd05.prod.outlook.com (2603:10b6:405:39::49) To AMSPR07MB311.eurprd07.prod.outlook.com (2a01:111:e400:802f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1992dff-124c-4a21-ce33-08d53da35d61 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603301);SRVR:AMSPR07MB311; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;3:rXvtDkhKSupsR37lKQ1xfpBD7aXwMx3NYE7E9Jszsa6g1ZBc7Zr7EVJ+8wcI+r5/k47T3/NXZWrQn1+DqDlvLNOn5vkmyHUd4/lspe5+nimxpb43nT5G+knfl53IqnaFgsJ+yMSzQdmJIgrZx6BIfzSqXqaHlS6pROqRd2vfivv6m3uN9R3GLoALxUfEkXx+BZV0xU/F8eGrWJSQ+qIIJaL833ch8Cvw0KNBjaQg9xCvFjWYXL/KB6nDNbqQkPLz;25:kYPhTFK5318vFYyvm9QnduIv9p/T8hlIl6ZF6IFsfVRQrOdS8mrCCGLbB3s/vbUz+obUuhGjVXOltW3lttX88Rl8Lsp7kVkiDqd+g30LJZF0jfa+FJ7+oTyR5rXnQDSgip2pPgkzs8CK80rQviN8BbQKkznTEqahErz1JvRnpbgvdcr4rA36+/hRcvoylQuRlX+cUpw+KXJxl9i0CruGwke0pPjaYDArwjq0zMdU4Z+bAqReGfdz0ObVg6LDoYHEjnCceSuOCCxvHvfVT6UlU8fUp/lWL9/csNyjClPusx0N+ZY2zH5NpBu+gPRtBW8PmY9drlxnY22F+BETKkUTlQ==;31:A5sm+fPj6Ombx2Si/EN0usvJUp5w24l7RsLSU4VLG91Wm5LEq8qRViidSmz5DzM6EFq/ypygXgqrvMon6A9mIVHTO06RzV57tMpw3HZxjdRxpRrOHV0FneVz5dPezSrAVRe+dIxQVonYiUUjOxMgXmARkpMHSUB9FFok7ClT6pIgMzC9FbbZ/UwUENlyz22wab0xZv4Ni3BfhN6O76XmlxX8XISHIAz5oXqqbH88dXU= X-MS-TrafficTypeDiagnostic: AMSPR07MB311: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;20:qwVHPYvEZdHiUhAhOUTJDJS+fzrKuvrQfdRlpYSZXA11mhdsHzyrmdcIWMGH/tR+Jrq9Mv8Z5JEOxoZfb2x+yW74lk+Z0krb/EtTTB1CAD6ujFeDCEe9eKsU0QcSe1mT2GNSjr29DMh1uWxaZHbf92pIJjWs95cCmZWBqkdPyEJJo0kOAKPETUF9A7Vl04XbJuNJWVtdGzrUjssG+7zfXzt4WiaCx79F7wO40EbAYlTg/lZZCZQl2DtATQCrlWFvzSljlG4wT4L917khKpmrFO/kceXDjTfyt6SfcQM3HdRvnvQHFgboU3ez200rWywOccjHPynz8+1TK9awfhmf/Pf39sUxMlCjSGkdaDLq9SPB5kzS+EBL93Q9cLxWq6hVwl/SNinszETB2jopD91ghUJZerjwhiFY68BwSGig87MNUVF2mfvaHqaYiSGNW84ESt7I2SFRUfQZuFu9iZkXN4Z+irw/YXBmphNP3w8/ZqTU78FTO35WxTNyamucGuaK;4:8bzV/4vdcNv5yImskW06+aC646T5Tmvo+c1j94aE13susJ5/Kjc1QOipGl64prutn/AKKcvNif44BFCSZqxGDFnTOx7FYo/A5lPieUQYNS/DQ+K/9e0C65nAregTO1myEvwC9hWBLPG5fZZZk3COVUiMzzUfBbQIIFJIzzubXGODUUoB0KpS5yxPfJyAMtblM/fHDygadJ2bvKC9q3DmajSj+0d4Z6+oqzeijYWJFStF9ba4jZsxwOQh58Yv1CArTjn6JhjNPpM287ePYN2w0I0dsLNskhe5JvSTmc8oGiM93RXqfcKRSozVXGxTQ+Yp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(3231022)(10201501046)(93006095)(93001095)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:AMSPR07MB311;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AMSPR07MB311; X-Forefront-PRVS: 05143A8241 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(376002)(346002)(366004)(199004)(189003)(13464003)(377424004)(24454002)(52146003)(31686004)(53546010)(66066001)(50466002)(65826007)(8676002)(6116002)(3846002)(68736007)(33646002)(230700001)(97736004)(76176011)(5660300001)(23676004)(52116002)(2486003)(8936002)(16526018)(65956001)(6486002)(305945005)(86362001)(65806001)(7736002)(36756003)(575784001)(106356001)(2906002)(64126003)(6246003)(105586002)(47776003)(2950100002)(6666003)(110136005)(2501003)(81156014)(101416001)(478600001)(25786009)(229853002)(53936002)(31696002)(81166006)(49976008)(83506002)(16576012)(316002)(58126008)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB311;H:[132.207.200.163];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTE7MjM6V094YytsTEhtQlpTaFJlZm1NNDNPYUxtelg2?= =?utf-8?B?ekk0WWhRVTBscFlPZVFFeUlZNzVTNGZEOXJ3K2RHMHNEYytvMWw1V2dtc0NW?= =?utf-8?B?blFjWkpSQmxlTzV0UTVhR1JNSlpFSVh6Yy9aVkQrZmZKd3Q4Z2VoSm1RYmVM?= =?utf-8?B?T3pXaVRwbXBsaXNMN0tseTVOTzQ0WllJMEFLclBqSmExZzlaL2tnK3UwZnVO?= =?utf-8?B?dE1LN3hhNlpoTFpyeVNrV0grUUFjTllTaTVmUWg2dzhjRmYyWGE5VkVnOHJE?= =?utf-8?B?MEsralVIdG1jQTVHNVFBLzNDMWh5SzB5eHRBZklOZGFGb3VoeG05OFZxRWFw?= =?utf-8?B?NFpLMm5lOFFBSDMzcVhORXFWRG1sMmhiZm9leVpQMTlrUUllUG5FSFlmRTlG?= =?utf-8?B?dC96amt5TDAzUlBRMExPL1RwU3pIenE1cSt2VUFNSDMrTEM2YTh2SVFSRFBv?= =?utf-8?B?ejdBeXdTTFNQQmw5Z3BWK215UzZXYWc0QWZxUWt1RDBGSTFQQk93UGFVVSt1?= =?utf-8?B?dVBHWmlIaE5tVFQ2SXhsTlZ1WmJvRXMrMG5MT2pzS3BzdXJJSUNHa3cxNXdz?= =?utf-8?B?UkdVRk1xWmhqbURqd0FsTVkxNXRFU3Y2QUFBR2ZYckJqUG1ib1JYNVo4VGRl?= =?utf-8?B?NysxRjltNUg1b2dhWU1jL09GSXNLK3JEMll0TlNiTDZWRGtiaVV0RkR6Y20r?= =?utf-8?B?RTZwQWl2ZkYxdlU4WXpqaWVCUDRGdW9VZlVhbUlnY0tFUlVsUTdSQ3RvWUFw?= =?utf-8?B?K0YzL3I2V0pRVTE2MS9uS1dpVkJoZCtOdGdiM2ttOG9aQUdiMWN0UVlKYkpF?= =?utf-8?B?a1NSczJCNlAwNmhiZ2JMNkx6d0NQT09iYmRoTFpIQUFTZ2FJd3R5SmNoSjlG?= =?utf-8?B?K3l4bEdLeTBYbEphM3pzNktTQ2UzS2pET1E3djF0NmxNS2J2WTJxaXRBUlJx?= =?utf-8?B?YUZEd3l4ZW9wVlArMWdVcUl3cm5yZnNsWVJXcFBkcFM1T3NacDdQVXg1QjVI?= =?utf-8?B?VDR6TDNYdmFWTGdWdERBZTkyZjRPTytCYzRxMm1wZFp0ZVo3SU0yU0IvZkhK?= =?utf-8?B?ZXNQNlJhRHF1dFB0YUZIaVc0UFRmMXBzcjBnNWp5Nk5SVHZ0RHFnVHVaUGE0?= =?utf-8?B?SXZrNjg0VEFDbUN0WUt6QWg1V05FVHZFc0pzdDRoWURydnMzMXZRbUdmY0Vz?= =?utf-8?B?TmFsOFJMRTNYc0VmcTV0VzZCZmFDUFg3WkE4TTRXQVlpcEVueVUyYXllUzRm?= =?utf-8?B?VnhNdEIvSklSOEVvZ1VqeHBvTWtNd0NGdXlpYWR0K1YrRDFQeDJRdHZiUDRt?= =?utf-8?B?bHpXRmRsaTRoa0oxdzEwTXV1Zm0wRmw1ekhXaWlzY0MyUzNNa0xZT2ZsSUhZ?= =?utf-8?B?UERDaWF4L21VVGR1bE9NYnBPNFRJcHd0WVA1aXY2bzRpSTBjSlNmYW5qejda?= =?utf-8?B?WG8rTlV4cGVsNWRiQURJK015cEpTU3doS1UveTdRRW1CSFhzZFpqaGM1UjVn?= =?utf-8?B?S1BsWnlLZjhTNHpucmdjT0VrNWJON0ljUUdaSDJjV2ZaV002V0pWd2JTQlBW?= =?utf-8?B?cVhkcU1uaXN0U0tRM3lCRU0vTFAwanQ5YjkxWDA1YkE3NVdDMjIxRnl2b25M?= =?utf-8?B?ekZ1MXBjTlhlQ3h5d2pSRTZpdzExSzErS3BCTmZ3eVpUbFBMdmhvVThTYU1Y?= =?utf-8?B?Q2pyQnlaRFRScURzOWUrNnlCZkFpQlUrenFQOHRzck02VUwrSHVETTh4Ky9z?= =?utf-8?B?RkErK3lUQkQwTTNtQmJWdW5JZnd4bU5EMWpDeE5CcDNWaE1ySjkrbEtIV3BR?= =?utf-8?B?VjUxU3hGUWxuaHpPZEJTSkNrbXkyQm5ja08xNWZLSXhOSE1KZXlybGtqUFgx?= =?utf-8?B?NzFLNXZ4SmM5Z2RoYVpGbFp3dTVlSGd0c042WXRQRGsvVVBXekRZclQvNVJU?= =?utf-8?B?eWNGRmRxUWc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;6:pM7/jTKTZly/e1v48JO34COWRyrp4Ig3uLpV4cZavGQxjjkplk4sUnD8sct+jfVn9yV8nwSmR4IVv7N4Lm7wn37/dIe/7xfdcVPrIrSwL/fBCdCnRj7wmy3wJSzIA9wXpHhEia2J66n32m+c+UBMp7V5CJNp0ffpcfse3wg7c9iS0a2vfKVUSc2uyMRTzuzo5+3X1zO8RgjFTofbWySNVfKT/4myifRXYcoh3BH/DIVZABSdCZLq126KV08O3Jw75j4DdH4wdL4ktRUf10KiDmhrwBw/cuPI6mtdcweBZq8dFdAgfVFlWy9v19cnkg3OISlPusIuTLbo27dK2Djn/N5WS2XHBX9aIBE9S5meMrI=;5:B0l7ZUlqJZa0NO4FhN18oXfmbLMH79CxK/2eWZ7rW36cGaeG/A+FQmH6vJ0H4EqkRcYcR/3Jcwu3Z/zfljonSu0Eo0YfgPZLgWy3VFDSy1wVUbUdC7flM3Sj3aYnUikIgtG2YYYmzIMjAp4glxeAkeoT0XiJJGXbs6u0xCKXhoE=;24:8rHlV1wht3oNmkySPmANEf9akP3Csc+JLoHnDhj8qOvq3U/3GUt2R55jRFdlAygnB9TLiSQXRu3WOebfwxEzf5QTPrOHI0lGDfdxj/EQJ4A=;7:wv4wGLug8jc+5+x+aQepLSEGhcz0r97TCNR8LdPzXbDZQjdfFQdtLSbMnC+o/8rvhLLkusClpnTlnbfYHKoGMuD6qow8CfT7FQX0iLNkVCQuVKPy1JaRzWDCpnGS9mU/CWxUp+efhX+K3b3Cm76MvLt4S+2cYy/W/RO0Q3p8xFZuPWn0jKutJyX030m3uBcWRebuZpWFslYWep5qb+aBWroSli3HmUAt+gMn2Fu25b440MNUuXHjgskMsb5h8BEz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2017 18:50:19.1728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1992dff-124c-4a21-ce33-08d53da35d61 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB311 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00146.txt.bz2 On 2017-12-07 09:49 AM, Metzger, Markus T wrote: > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Simon Marchi > Sent: 02 December 2017 17:50 > To: gdb-patches@sourceware.org > Cc: Simon Marchi > Subject: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector > > Hello Simon, > > diff --git a/gdb/btrace.c b/gdb/btrace.c index 8338ebfb0a..547f43d691 100644 > --- a/gdb/btrace.c > +++ b/gdb/btrace.c > @@ -2004,10 +2004,11 @@ btrace_free_objfile (struct objfile *objfile) static void check_xml_btrace_version (struct gdb_xml_parser *parser, > const struct gdb_xml_element *element, > - void *user_data, VEC (gdb_xml_value_s) *attributes) > + void *user_data, > + std::vector &attributes) > { > const char *version > - = (const char *) xml_find_attribute (attributes, "version")->value; > + = (const char *) xml_find_attribute (attributes, > + "version")->value.get (); > > This looks a bit odd. Can you clarify what looks odd? In your quote, there appears to be two added lines (two +): > - = (const char *) xml_find_attribute (attributes, "version")->value; > + = (const char *) xml_find_attribute (attributes, > + "version")->value.get (); But in my patch it's all on the same line. I am confused. > @@ -2040,8 +2042,8 @@ parse_xml_btrace_block (struct gdb_xml_parser *parser, > gdb_xml_error (parser, _("Btrace format error.")); > } > > - begin = (ULONGEST *) xml_find_attribute (attributes, "begin")->value; > - end = (ULONGEST *) xml_find_attribute (attributes, "end")->value; > + begin = (ULONGEST *) xml_find_attribute (attributes, > + "begin")->value.get (); end = (ULONGEST *) xml_find_attribute > + (attributes, "end")->value.get (); > > This too. Same thing here. Simon