From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5700 invoked by alias); 13 Feb 2020 20:28:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5686 invoked by uid 89); 13 Feb 2020 20:28:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=write_memory X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 20:28:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581625697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98ibBVKkbnJLu2TuGL94YmAqn93Mga9NVnyq6Wd15Zc=; b=G3qO4Ozkt6cnZ6plP8L1VsyEuihM+XaRpX3wnIFKrs52DbJ/gZxA75k2modO42qciN9Xj8 pvR44POVjNWqQR0UyZTc8mcKCdJez/f5qyh+iZgBryaXCFmOO6q9oqUf0ujI8UNbzFvmgB uDY5S5yq4xpPx3a+JSkILzIEY+O2+7M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-QTcMiKYIMyWG86ZR_uqo0g-1; Thu, 13 Feb 2020 15:28:15 -0500 Received: by mail-wm1-f70.google.com with SMTP id y7so2811314wmd.4 for ; Thu, 13 Feb 2020 12:28:15 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id p5sm4120535wrt.79.2020.02.13.12.28.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2020 12:28:13 -0800 (PST) Subject: Re: [PATCH 15/58] gdbserver: turn target op 'look_up_symbols' into a method To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <9a549a34d4c48d61e63c5d997daca31b298af533.1581410933.git.tankut.baris.aktemur@intel.com> From: Pedro Alves Message-ID: <914b907d-4a58-05cd-321e-a6c5553cf424@redhat.com> Date: Thu, 13 Feb 2020 20:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <9a549a34d4c48d61e63c5d997daca31b298af533.1581410933.git.tankut.baris.aktemur@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00529.txt.bz2 On 2/11/20 9:01 AM, Tankut Baris Aktemur wrote: > @@ -476,6 +468,13 @@ public: > Returns 0 on success and errno on failure. */ > virtual int write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, > int len) = 0; > + > + /* Query GDB for the values of any symbols we're interested in. > + This function is called whenever we receive a "qSymbols::" > + query, which corresponds to every time more symbols (might) > + become available. NULL if we aren't interested in any > + symbols. */ This "NULL if we aren't interested ..." remark no longer makes sense, since a method can never be null. Please double-check whether other methods need similar adjustment as well. > + virtual void look_up_symbols (); Thanks, Pedro Alves