From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: lrn1986@gmail.com, gdb-patches@sourceware.org
Subject: Re: Fix compilation using mingw.org's MinGW
Date: Tue, 30 Apr 2019 18:38:00 -0000 [thread overview]
Message-ID: <9168119e-b3a9-5a4e-e169-377ddb9e7a48@redhat.com> (raw)
In-Reply-To: <83o94nqr4g.fsf@gnu.org>
On 4/30/19 7:34 PM, Eli Zaretskii wrote:
>> Cc: lrn1986@gmail.com, gdb-patches@sourceware.org
>> From: Pedro Alves <palves@redhat.com>
>> Date: Tue, 30 Apr 2019 18:58:42 +0100
>>
>> In fact, your patch is doing exactly that. common-defs.h is garanteed
>> to be included before any started header. That's exactly why I suggested
>> that spot.
>
> You were talking about the patch for master, whereas I was talking
> about the patch for the release branch.
Ah, indeed it seemed like we were kind of talking past each other.
Still, my remarks apply likewise (we don't _have_ to define after
the standard headers, before is fine and is the standard practice).
But what I had in the 8.3 patch is fine as is, TBC.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-04-30 18:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 15:36 Eli Zaretskii
2019-04-18 17:01 ` Kevin Buettner
2019-04-18 18:54 ` Eli Zaretskii
2019-04-18 20:38 ` Kevin Buettner
2019-04-19 6:19 ` Eli Zaretskii
2019-04-18 17:20 ` Pedro Alves
2019-04-18 17:22 ` Pedro Alves
2019-04-18 18:57 ` Eli Zaretskii
2019-04-19 10:51 ` Pedro Alves
2019-04-19 11:23 ` Eli Zaretskii
2019-04-19 11:33 ` Pedro Alves
2019-04-28 14:33 ` Eli Zaretskii
2019-04-30 12:56 ` Pedro Alves
2019-04-30 13:06 ` LRN
2019-04-30 15:25 ` Eli Zaretskii
2019-04-30 17:04 ` Pedro Alves
2019-04-30 17:17 ` Eli Zaretskii
2019-04-30 17:26 ` Pedro Alves
2019-04-30 17:40 ` Eli Zaretskii
2019-04-30 17:58 ` Pedro Alves
2019-04-30 18:34 ` Eli Zaretskii
2019-04-30 18:38 ` Pedro Alves [this message]
2019-04-30 17:50 ` LRN
2019-04-30 13:10 ` Pedro Alves
2019-04-30 15:23 ` Eli Zaretskii
2019-04-30 16:31 ` Pedro Alves
2019-05-03 8:04 ` Eli Zaretskii
2019-05-03 8:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9168119e-b3a9-5a4e-e169-377ddb9e7a48@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=lrn1986@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).