From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74061 invoked by alias); 23 Mar 2018 17:04:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74041 invoked by uid 89); 23 Mar 2018 17:04:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Mar 2018 17:04:54 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w2NH4lCd003526 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 23 Mar 2018 13:04:52 -0400 Received: by simark.ca (Postfix, from userid 112) id DFB751E77E; Fri, 23 Mar 2018 13:04:47 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E45B01E4B2; Fri, 23 Mar 2018 13:04:46 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 23 Mar 2018 17:04:00 -0000 From: Simon Marchi To: Alan Hayward Cc: Simon Marchi , gdb-patches@sourceware.org, nd Subject: Re: [PATCH v4 02/10] Make gdbserver reg_defs a vector of objects In-Reply-To: References: <20180322084429.26250-1-alan.hayward@arm.com> <20180322084429.26250-3-alan.hayward@arm.com> <74733d19-17a0-6a38-73d0-e1201f27d5cd@ericsson.com> <11092a287454586f60c73937a37bc4db@polymtl.ca> Message-ID: <916b23868a067d1f6d0b626ab3bee5a9@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 23 Mar 2018 17:04:48 +0000 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00448.txt.bz2 On 2018-03-23 12:52, Alan Hayward wrote: >> The offset value is always 0 initially, so you can remove it and >> initialize it to 0. >> > > Reason I added offset here was that in "Commonise tdesc_reg” this code > will get merged into init_target_desc(). > At that point I’ll be creating a reg and setting and offset at the same > time. > This was just so that I didn’t need to touch regdef.h again. > > I can still remove offset from this patch if you want - given that I’m > not using it yet? This it not terribly important, but I think it's better to only add it once you really need it. The proposed patches could change, and the parameter could end up unused (not saying that's what will happen here, it's just an example). Simon