[PATCH] Fix type of expr in info_mach_region_command (fixes OSX build)

[PATCH] Fix type of expr in info_mach_region_command (fixes OSX build)

[Manish Goregaokar]

gdb wasn't building on OSX. Colleague fixed it.

error was

darwin-nat-info.c:733:8: error: assigning to 'struct expression *'
from incompatible type 'expression_up' (aka
      'std::__1::unique_ptr<expression, gdb::xfree_deleter<expression> >')
  expr = parse_expression (exp);
       ^ ~~~~~~~~~~~~~~~~~~~~~~


-----

2016-12-15 Boris Zbarsky  <bzbarsky@mozilla.com>

gdb/ChangeLog:
    * darwin-nat-info.c (info_mach_region_command): Update
    type of `expr` to `expression_up`
---
 gdb/darwin-nat-info.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/darwin-nat-info.c b/gdb/darwin-nat-info.c
index 314d265..a74938a 100644
--- a/gdb/darwin-nat-info.c
+++ b/gdb/darwin-nat-info.c
@@ -725,13 +725,13 @@ info_mach_regions_recurse_command (char *args,
int from_tty)
 static void
 info_mach_region_command (char *exp, int from_tty)
 {
-  struct expression *expr;
+  expression_up expr;
   struct value *val;
   mach_vm_address_t address;
   struct inferior *inf;

   expr = parse_expression (exp);
-  val = evaluate_expression (expr);
+  val = evaluate_expression (expr.get());
   if (TYPE_CODE (value_type (val)) == TYPE_CODE_REF)
     {
       val = value_ind (val);
-- 
2.10.1

Re: [PATCH] Fix type of expr in info_mach_region_command (fixes OSX build)

[Pedro Alves]

On 12/15/2016 08:17 PM, Manish Goregaokar wrote:
> gdb wasn't building on OSX. Colleague fixed it.
> 
> error was
> 
> darwin-nat-info.c:733:8: error: assigning to 'struct expression *'
> from incompatible type 'expression_up' (aka
>       'std::__1::unique_ptr<expression, gdb::xfree_deleter<expression> >')
>   expr = parse_expression (exp);
>        ^ ~~~~~~~~~~~~~~~~~~~~~~
> 

Oh, I just approved Bernhard's patch without noticing this one,
sorry about that:

 https://sourceware.org/ml/gdb-patches/2016-12/msg00318.html

I prefer his version for moving the declaration, but any
is fine...

Thanks,
Pedro Alves