From: John Baldwin <jhb@FreeBSD.org>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Improve 'maint set target-async off' for remote targets
Date: Tue, 23 Nov 2021 08:39:31 -0800 [thread overview]
Message-ID: <91a59653-057d-c965-94c3-3918042b33e3@FreeBSD.org> (raw)
In-Reply-To: <cover.1637676250.git.aburgess@redhat.com>
On 11/23/21 6:08 AM, Andrew Burgess via Gdb-patches wrote:
> While working on another patch that involved extended-remote targets
> and attaching I tried testing with 'maint set target-non-stop off' and
> 'maint set target-async off' and ran into some problems.
>
> This series is my attempt to improve the extended-remote's support for
> 'maint set target-async off'.
I think this looks ok. I had some changes related to async mode in my
series to enable async for FreeBSD that I think compose with these
(as opposed to conflicting). In particular, I fixed target_wait to use
is_async instead of can_async when deciding to permit WNOHANG and I also
pulled some of the can_async checks further up into the core and out
of targets in a few places.
--
John Baldwin
next prev parent reply other threads:[~2021-11-23 16:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 14:08 Andrew Burgess
2021-11-23 14:08 ` [PATCH 1/4] gdb: add asserts in target.c for target_async_permitted Andrew Burgess
2021-11-23 21:31 ` Simon Marchi
2021-11-23 14:08 ` [PATCH 2/4] gdb/remote: merge ::is_async_p and ::can_async_p methods Andrew Burgess
2021-11-23 21:33 ` Simon Marchi
2021-11-24 10:14 ` Andrew Burgess
2021-11-23 14:08 ` [PATCH 3/4] gdb: add assert in remote_target::wait relating to async being off Andrew Burgess
2021-11-23 21:50 ` Simon Marchi
2021-11-23 14:08 ` [PATCH 4/4] gdb/remote: some fixes for 'maint set target-async off' Andrew Burgess
2021-11-23 22:03 ` Simon Marchi
2021-11-23 16:39 ` John Baldwin [this message]
2021-11-24 12:22 ` [PATCHv2 0/6] Improve 'maint set target-async off' for remote targets Andrew Burgess
2021-11-24 12:22 ` [PATCHv2 1/6] gdb: introduce a new overload of target_can_async_p Andrew Burgess
2021-11-24 12:22 ` [PATCHv2 2/6] gdb: hoist target_async_permitted checks into target.c Andrew Burgess
2021-11-24 21:17 ` Simon Marchi
2021-11-24 12:22 ` [PATCHv2 3/6] gdb: add asserts in target.c for target_async_permitted Andrew Burgess
2021-11-24 21:21 ` Simon Marchi
2021-11-24 12:22 ` [PATCHv2 4/6] gdb: simplify remote_target::is_async_p Andrew Burgess
2021-11-24 12:22 ` [PATCHv2 5/6] gdb: add assert in remote_target::wait relating to async being off Andrew Burgess
2021-11-24 21:23 ` Simon Marchi
2021-11-25 10:04 ` Andrew Burgess
2021-11-25 11:36 ` Tom de Vries
2021-11-25 13:46 ` Andrew Burgess
2021-11-25 14:17 ` Tom de Vries
2021-11-24 12:22 ` [PATCHv2 6/6] gdb/remote: some fixes for 'maint set target-async off' Andrew Burgess
2021-12-01 10:40 ` [PATCHv3 0/2] Improve 'maint set target-async off' for remote targets Andrew Burgess
2021-12-01 10:40 ` [PATCHv3 1/2] gdb/remote: some fixes for 'maint set target-async off' Andrew Burgess
2021-12-16 21:15 ` Pedro Alves
2021-12-17 13:35 ` Andrew Burgess
2021-12-17 14:05 ` Pedro Alves
2021-12-18 10:21 ` Andrew Burgess
2021-12-01 10:40 ` [PATCHv3 2/2] gdb: add assert in remote_target::wait relating to async being off Andrew Burgess
2021-12-16 21:16 ` Pedro Alves
2021-12-18 10:21 ` Andrew Burgess
2021-12-13 11:41 ` PING: [PATCHv3 0/2] Improve 'maint set target-async off' for remote targets Andrew Burgess
2021-12-13 17:20 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91a59653-057d-c965-94c3-3918042b33e3@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).