From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by sourceware.org (Postfix) with ESMTPS id 4FEC33858C50 for ; Thu, 31 Mar 2022 10:04:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4FEC33858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id a1so32983436wrh.10 for ; Thu, 31 Mar 2022 03:04:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gJ40na8qr1VBdd6fua56UY9Ra8V4RPbtHdbXJzq+nC0=; b=x9LwgmUFF4NhabtHTCnfFiti5qhIByU8IIpbHPekHBltGNR1aKMl32mzvlhQp+eEsh KEGLT5I0Seo0O9Y9pAHQRBFEcEdilsecMkO0GUNW/iFZOY4oHe2htDsRqgrjgNsuMQGD rsL+chZmNppUd43PNnd7+jNQf3sdMIhrMBnr2fvlaalFvX0jQ/5NEL7EIazvhNzYDvVz e2MbJVaLGQPEfCU3HeNgRqZrl17Mwn7wAU2ug9kmSo1sBrSdtKEu7LgMvLEXvJsb6sQx 9Xoh7VH68ws2WBerAbGayP3pKNIBOXCgn5soD8IcZDMIfGk9eCQl1t4o5ne+Ld9oamrl waWg== X-Gm-Message-State: AOAM531732/fSszveUbRDnp/5gkuLI9Ni1eEMRTRegrrnAgY3MlOMQzF oRd3sIQpe8WrfzExsW76fDr1kF4+YncsXg== X-Google-Smtp-Source: ABdhPJw7+BX21vk5DxyEQ03OUzdJA/1UIyenkYQeJkLrg8mbW/gSvPEp7fOqcpme4DG2UHpy6EBeuA== X-Received: by 2002:a05:6000:1d83:b0:203:ed96:fa4c with SMTP id bk3-20020a0560001d8300b00203ed96fa4cmr3541568wrb.400.1648721083299; Thu, 31 Mar 2022 03:04:43 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id 61-20020adf8043000000b00205e1d92a41sm2143615wrk.74.2022.03.31.03.04.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 03:04:42 -0700 (PDT) Message-ID: <91b4b5fd-b05b-73ad-f3f3-8c662e7544eb@palves.net> Date: Thu, 31 Mar 2022 11:04:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] gdb/buildsym: Line record use a record flag Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20220330093458.148497-1-lancelot.six@amd.com> <20220330093458.148497-2-lancelot.six@amd.com> From: Pedro Alves In-Reply-To: <20220330093458.148497-2-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 10:04:46 -0000 On more thing I noticed while looking at patch #2: On 2022-03-30 10:34, Lancelot SIX via Gdb-patches wrote: > +/* Flags associated with a linetable entry. */ > + > +enum linetable_entry_flag : unsigned > +{ > + LEF_IS_STMT = 1 << 1, Could you add a comment documenting what each flag means, please. Here for IS_STMT, I guess you can just copy the comment from linetable_entry: /* True if this PC is a good location to place a breakpoint for LINE. */ unsigned is_stmt : 1; > +}; > +DEF_ENUM_FLAGS_TYPE (enum linetable_entry_flag, linetable_entry_flags); > +