From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 666433851408 for ; Thu, 21 Jul 2022 02:30:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 666433851408 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F12581E222; Wed, 20 Jul 2022 22:30:23 -0400 (EDT) Message-ID: <91d4f1a1-4554-85e7-dccf-0e1f373c6119@simark.ca> Date: Wed, 20 Jul 2022 22:30:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 06/29] Avoid duplicate QThreadEvents packets Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> <20220713222433.374898-7-pedro@palves.net> From: Simon Marchi In-Reply-To: <20220713222433.374898-7-pedro@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 02:30:25 -0000 On 2022-07-13 18:24, Pedro Alves wrote: > Similarly to QProgramSignals and QPassSignals, avoid sending duplicate > QThreadEvents packets. > > Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4 > --- > gdb/remote.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/gdb/remote.c b/gdb/remote.c > index c0bd075e9e5..00ed82dc466 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -314,6 +314,10 @@ class remote_state > the target know about program signals list changes. */ > char *last_program_signals_packet = nullptr; > > + /* Similarly, the last QThreadEvents state we sent to the > + target. */ > + bool last_thread_events; This field is read before it is ever set, isn't it bad? Simon