Re: [PATCH] [gdb] Mention --with/without-system-readline for --configuration

[Tom de Vries <tdevries@suse.de>]

On 5/30/23 15:36, Simon Marchi wrote:
> On 5/30/23 05:33, Tom de Vries wrote:
>> Simon reported that the new test-case gdb.tui/pr30056.exp fails with system
>> readline.
>>
>> This is because the test-case requires a fix in readline that's present in our
>> in-repo copy of readline, but most likely not in any system readline yet.
>>
>> Fix this by:
>> - mentioning --with-system-readline or --without-system-readline in the
>>    configuration string.
>> - adding a new proc with_system_readline that makes this information available
>>    in the testsuite.
>> - using this in test-case gdb.tui/pr30056.exp to declare it unsupported for
>>    --with-system-readline.
>>
>> Tested on x86_64-linux.
>>
>> Reported-By: Simon Marchi <simon.marchi@efficios.com>
> 
> I confirm this makes the test skipped on my machine.
> 
> Once the fix is merged and in a readline release, could we make the skip
> conditional on the readline version?  We could have a maintenance
> command or something like that that outputs RL_READLINE_VERSION, and
> skip only for old readline versions.

We could do that, that sounds useful.

I also considered printing the readline version string after 
--with/without-system-readline, but it looked a bit too different to all 
the other lines.

Do you want have this implemented before, or are ok with the fix as is?

Thanks,
- Tom